Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to the enclosing type of a function aren't not taken into account after Create Declaration / Definition is used once #10162

Closed
sean-mcmanus opened this issue Nov 17, 2022 · 0 comments
Closed

Changes to the enclosing type of a function aren't not taken into account after Create Declaration / Definition is used once #10162

sean-mcmanus opened this issue Nov 17, 2022 · 0 comments
Assignees
@michelleangela
Labels
bug Feature: Create Declaration or Definition fixed Check the Milestone for the release in which the fix is or will be available. insiders Currently only repros with our latest Insiders release. Language Service Works in VS So we'd need to fix it for VS Code to reach parity.
Milestone
1.14.0

Comments

@sean-mcmanus
Copy link
Collaborator

Do Creation Declaration/Definition on a function in a class/namespace/etc. Then rename a surrounding scope (or change some aspect of it, since as whether it's templated, etc.).

Bug: The old name or type info is used instead of the updated one. It's fixed after a reload window is done.
@sean-mcmanus sean-mcmanus added bug Language Service insiders Currently only repros with our latest Insiders release. Works in VS So we'd need to fix it for VS Code to reach parity. Feature: Create Declaration or Definition labels Nov 17, 2022
@michelleangela michelleangela self-assigned this Nov 18, 2022
@sean-mcmanus sean-mcmanus added this to the 1.14.0 milestone Dec 7, 2022
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Dec 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michelleangela michelleangela

Labels
bug Feature: Create Declaration or Definition fixed Check the Milestone for the release in which the fix is or will be available. insiders Currently only repros with our latest Insiders release. Language Service Works in VS So we'd need to fix it for VS Code to reach parity.
Projects
None yet
Milestone
1.14.0
Development

No branches or pull requests
2 participants
@sean-mcmanus @michelleangela