Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display property changed instead of font-display #96

Closed
miguelsolorio opened this issue Jan 25, 2022 · 0 comments
Closed

display property changed instead of font-display #96

miguelsolorio opened this issue Jan 25, 2022 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@miguelsolorio
Copy link

via @tchebb

can you explain how this change is related to the change in microsoft/vscode#131396? That change altered the font-display property, which controls browser timeouts in the case the font is slow to load. This change alters the display property, which changes how other text on the page is laid out relative to the codicon. The two have no relation to one another as far as I can tell.

This change seems quite undesirable, as it puts the codicon in its own box that fills the entire width of the container it's in instead of keeping it inline with the text around it. Is there any case where we want this as the default behavior?

@miguelsolorio miguelsolorio added the bug Issue identified by VS Code Team member as probable bug label Jan 25, 2022
@miguelsolorio miguelsolorio self-assigned this Jan 25, 2022
@miguelsolorio miguelsolorio added this to the January 2022 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

1 participant