Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Add support for sub-targets via new Targets domain #251

Closed
5 tasks
auchenberg opened this issue Oct 27, 2017 · 6 comments
Closed
5 tasks

Add support for sub-targets via new Targets domain #251

auchenberg opened this issue Oct 27, 2017 · 6 comments
Assignees

Comments

@auchenberg
Copy link
Contributor

auchenberg commented Oct 27, 2017

It's expected for Node to land the new CDP Target domain to allow debugging child Node processes, within the next months per nodejs/diagnostics#75 (comment), and Chrome seems to motivated to move the Target domain for discovery.

We should explore how the Target domain works, and how much difference there is between the current HTTP discovery.

  • Can we replace HTTP discovery with the new Target domain
  • Explore how to model sub-targets into threads and new processes within VS Code UX
  • How would Node child processes be surfaced?
  • How would WebWorkers processes be surfaced?
  • How would ServiceWorkers processes be surfaced?
@auchenberg
Copy link
Contributor Author

Feedback from @joshgav

My gut is that processes created with Node's child_process and cluster modules should be treated as processes since they spin up new OS processes, and Web service workers should be treated as threads as they (at least appear to) wrap a func/script.

There are occasional rumblings about supporting Service Worker and true OS threads in Node.js, such as in https://github.com/nodejs/worker (see the tracker there), so if that ever happens you'd mimic the web Service Worker experience for Node.

@aleclarson
Copy link

This would be super useful for debugging React Native from VS Code. 😄

@GitStorageOne
Copy link

GitStorageOne commented Jul 22, 2019

Node now supports workers, so we need a debug tool. Please.

@MichaelLiss
Copy link

Please add support for workers ( https://nodejs.org/api/worker_threads.html )

@DemoTenant
Copy link

Please add support to debug workers

@roblourens
Copy link
Member

This is supported by vscode-js-debug now.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants