Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg-tool] Add a cmake preset for boostrap-vcpkg.sh #37958

Closed
SchaichAlonso opened this issue Apr 3, 2024 · 0 comments · Fixed by microsoft/vcpkg-tool#1380
Closed

[vcpkg-tool] Add a cmake preset for boostrap-vcpkg.sh #37958

SchaichAlonso opened this issue Apr 3, 2024 · 0 comments · Fixed by microsoft/vcpkg-tool#1380

Comments

@SchaichAlonso
Copy link
Contributor

scripts/bootrap.sh does some rather interesting composition of a cmake call around lines 214 which results in having to use eval to get rid of the double-escaping of some strings.

Further, the ninja-specific multi-task build job rules are quite nasty and probably don't provide us with anything that passing --parallel to cmake --build could also do.

Add a CMakePreset.json representing the cmake invokation of bootstrap.sh, and replace the ninja specific code by --build - or - if the ninja specialization has to stay, derive a ninja multi-tasking preset from the regular, which allows simplifying the bootstrap script, as well as invoking cmake in a vcpkg-tool checkout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant