Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Static VS Analysis Working in OneBranch #6

Open
nibanks opened this issue Dec 16, 2023 · 4 comments
Open

Get Static VS Analysis Working in OneBranch #6

nibanks opened this issue Dec 16, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@nibanks
Copy link
Member

nibanks commented Dec 16, 2023

The props file currently disables static VS analysis when running in the official build. We need to work with the necessary team(s) to get this fixed.

@nibanks nibanks added the bug Something isn't working label Dec 16, 2023
@mtfriesen
Copy link
Contributor

@nibanks is this still a problem? I believe XDP has been building with static analysis.

@nibanks
Copy link
Member Author

nibanks commented Aug 28, 2024

We only set <RunCodeAnalysis>true</RunCodeAnalysis> when not in OneBranch.

@mtfriesen
Copy link
Contributor

We only set <RunCodeAnalysis>true</RunCodeAnalysis> when not in OneBranch.

Yep, I'm asking if we still need to make that conditional. In XDP we had been setting RunCodeAnalysis unconditionally, and not hitting issues in OneBranch.

@nibanks
Copy link
Member Author

nibanks commented Aug 28, 2024

I'd love to remove this then. Let's try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants