From 6262ac100dd92a0ce0139914b5c3b8994ddbf819 Mon Sep 17 00:00:00 2001 From: Mike Griese Date: Fri, 28 Jan 2022 09:41:43 -0600 Subject: [PATCH] Change where the NotificationIcon looks up our resources MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I didn't have the tray icon enabled before I suppose, so this never got hit? Anyhow, we need to change where we look for the AppName. Otherwise we crash on launch 😨 * [x] fixes `main` * [x] I work here * regressed in #12264 --- src/cascadia/WindowsTerminal/NotificationIcon.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cascadia/WindowsTerminal/NotificationIcon.cpp b/src/cascadia/WindowsTerminal/NotificationIcon.cpp index dadc320a14d..89e865f64ad 100644 --- a/src/cascadia/WindowsTerminal/NotificationIcon.cpp +++ b/src/cascadia/WindowsTerminal/NotificationIcon.cpp @@ -82,8 +82,8 @@ void NotificationIcon::CreateNotificationIcon() nid.uCallbackMessage = CM_NOTIFY_FROM_NOTIFICATION_AREA; - // AppName happens to be in CascadiaPackage's Resources. - ScopedResourceLoader loader{ L"Resources" }; + // AppName happens to be in the ContextMenu's Resources, see GH#12264 + ScopedResourceLoader loader{ L"TerminalApp/ContextMenu" }; const auto appNameLoc = loader.GetLocalizedString(L"AppName"); nid.hIcon = static_cast(GetActiveAppIconHandle(true));