Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme change does not apply properly to settings UI #9716

Closed
DHowett opened this issue Apr 6, 2021 · 9 comments
Closed

Theme change does not apply properly to settings UI #9716

DHowett opened this issue Apr 6, 2021 · 9 comments
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Milestone
Terminal v2.0

Comments

@DHowett
Copy link
Member

DHowett commented Apr 6, 2021

image

originated in 4/2 bug bash
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 6, 2021
@zadjii-msft zadjii-msft added Area-Settings UI Anything specific to the SUI Priority-3 A description (P3) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Apr 6, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 6, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Apr 6, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 6, 2021
@carlos-zamora
Copy link
Member

@zadjii-msft just to be clear, this is an "easy-starter" because you have to basically do what we did in #9732 to the entire SUI?

@zadjii-msft
Copy link
Member

I think it's even easier than that. We probably don't need to do the whole recursive dance. We might be able to just set RequestedTheme on the MainPage itself. I only did the recursive-upwards thing because I presumed that TeachingTips were the same weird edge case that ContentDialogs were.

@Don-Vito
Copy link
Contributor

I cannot reproduce it - any specific steps?

@carlos-zamora carlos-zamora mentioned this issue May 15, 2021
Merged
@carlos-zamora
Copy link
Member

I was able to get a similar issue over in #9949. Couldn't get the resource to appear when the app's theme was different from the Windows OS theme.

Setting RequestedTheme on MainPage didn't fix it 😢

@Albert-Jokelin
Copy link

Hey! Can I work on this?

@zadjii-msft
Copy link
Member

@Albert-Jokelin Sure, go right ahead! Though, we maybe should have yanked Easy-Starter off this one... if "Setting RequestedTheme on MainPage didn't fix it", then I'm not really sure where to start with this.

@zadjii-msft zadjii-msft removed the good first issue This is a fix that might be easier for someone to do as a first contribution label Aug 30, 2021
@zadjii-msft zadjii-msft changed the title [BASH] Theme change does not apply properly to settings UI Theme change does not apply properly to settings UI Aug 30, 2021
@Albert-Jokelin
Copy link

I'll try my best and if I need any help, I'll reach out to you guys.

@Albert-Jokelin
Copy link

@zadjii-msft I'm unable to recreate the issue. I'm running Windows 10 Home Ver. 20H2, Build: 19042.928

@zadjii-msft
Copy link
Member

Son of a gun, you're right. Huh. Wonder when that got fixed? Glad to know it is though! Thanks for helping check that one out!

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Aug 31, 2021
@zadjii-msft zadjii-msft added Resolution-Fix-Available It's available in an Insiders build or a release and removed Needs-Tag-Fix Doesn't match tag requirements labels Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Projects
None yet
Milestone
Terminal v2.0
Development

No branches or pull requests
5 participants
@DHowett @Don-Vito @carlos-zamora @zadjii-msft @Albert-Jokelin