Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu font rendering incorrectly (extremely wide) #9393

Closed
ebrodlic opened this issue Mar 5, 2021 · 6 comments
Closed

Ubuntu font rendering incorrectly (extremely wide) #9393

ebrodlic opened this issue Mar 5, 2021 · 6 comments
Labels
Area-Fonts Related to the font Issue-Question For questions or discussion Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered

Comments

@ebrodlic
Copy link

ebrodlic commented Mar 5, 2021

Environment

Windows build number: Microsoft Windows [Version 10.0.19042.844]
Windows Terminal version (if applicable): Version: 1.6.10571.0

Ubuntu 20.04.2 LTS for WSL2
Ubuntu (Font) 0.83 Dalton Maag Ltd

Steps to reproduce

In the Windows Terminal settings.json, set the entry "fontFace": "Ubuntu" for any profile and list out the directory structure.

Expected behavior

Entries get printed out with a font that resembles the Ubuntu font in the font preview app:
image

Actual behavior

The rendered font has the look of the Ubuntu one, but the horizontal spacing of characters is extremely wide (due to excess whitespace):
image

Example with command-prompt profile using the same font:
image

Additional Info

I am not sure where the Ubuntu (Font) 0.83 Dalton Maag Ltd font came from, as I cant seem to uninstall it with the fonts app. (Perhaps while installing Ubuntu LTS via the store?).

Weirdly, the font was actually rendering fine until today, when Terminal complained about the inability find the "Ubuntu-R" font which was installed and set previously by me. (Off of the Ubuntu Font official site). The custom font has the same version (0.83), but the actual registered name was "Ubuntu-R", which now suddenly shows just as "Ubuntu" and conflicts with the built-in one.

Reinstalling the custom downloaded one has no effect on Windows Terminal.

Details:
image

Custom downloaded font:
image

After install:
image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 5, 2021
@KalleOlaviNiemitalo
Copy link

There is related discussion in #3498 and #7596.

@ebrodlic
Copy link
Author

ebrodlic commented Mar 5, 2021

Thanks for chipping in @KalleOlaviNiemitalo but those discussions seem to be related to line (vertical) height?
Concretely line height, not font size.

I am talking about horizontal whitespace between characters (almost as if its some forced extra wide monospaced font), and I am quite happy with vertical line height.

@skyline75489
Copy link
Collaborator

Funny that this happens to me a lot when I'm using Linux terminals with a non-monospace font. Can you try the UbuntuMono to see if it helps?

@zadjii-msft
Copy link
Member

Yea, I agree with @skyline75489's thought here. Can you try "Ubuntu Mono" instead? Just plain "Ubuntu" technically isn't a monospace font, so we're probably calculating the wrong width for all those glyphs.

@zadjii-msft zadjii-msft added Area-Fonts Related to the font Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 8, 2021
@ebrodlic
Copy link
Author

ebrodlic commented Mar 8, 2021

I've tried "Ubuntu Mono" and it looks great!
Thanks for the tip @zadjii-msft and @skyline75489

Is WT intended to be using monospaced fonts?

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 8, 2021
@zadjii-msft
Copy link
Member

@ebrodlic Yea, monospaced fonts are definitely the way to go. The Terminal will let you set whatever font you want, but monospaced ones are the only ones that'll really work right. If you set it to Papyrus and get weird rendering, that's on you 😆

@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Fonts Related to the font Issue-Question For questions or discussion Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

4 participants