Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl+c hot keys #8396

Closed
EfimenkoAndrew opened this issue Nov 25, 2020 · 4 comments
Closed

ctrl+c hot keys #8396

EfimenkoAndrew opened this issue Nov 25, 2020 · 4 comments
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity.

Comments

@EfimenkoAndrew
Copy link

EfimenkoAndrew commented Nov 25, 2020

Environment

Windows build number: Microsoft Windows [Version 10.0.18363.1198]
Windows Terminal version (if applicable): 1.4.3243.0


Any other software? No

Steps to reproduce

  1. Open the terminal
  2. Open PowerShell tab
  3. Select text
  4. Press ctrl+c to copy it
  5. Press ctrl+v to pass the copied values

Expected behavior

The same behaviour as Windows PowerShell or ConEmu
image

Actual behavior

image
The ctrl+v passes the previously copied value. It is very uncomfortable to use Windows Terminal after PowerShell. Please fix that. I am not sure that CMD behaviour is actually expected one.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 25, 2020
@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 25, 2020

The default bindings (for all versions of terminal) are:

  • copy - ctrl+shift+c / ctrl+insert
  • paste - ctrl+shift+v / shift+insert

You can also bind ctrl+c / ctrl+v at your own risk (as it might be a disabler for some scenarios) by adding the following to keybindings (if you are in 1.4 and above, you are encouraged to use "actions" field rather than "keybindings") in settings file:

{ "command": {"action": "copy", "singleLine": false }, "keys": "ctrl+c" },
{ "command": "paste", "keys": "ctrl+v" }

Please read more about bindings here: https://docs.microsoft.com/en-us/windows/terminal/customize-settings/actions

BTW, if you need to learn additional shortcuts or even to apply actions without shortcuts - press ctrl+shift+p to open a command palette with all available commands and shortcuts.

Updated @EfimenkoAndrew - please pay attention that I adjusted the bindings, to the defaults suggested by the team.

@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 25, 2020

@EfimenkoAndrew - btw do you have a fresh installation?

Interestingly, according to #5187, the following should appear by default in your settings file (but I guess this happens only if you don't have an old one):

{ "command": {"action": "copy", "singleLine": false }, "keys": "ctrl+c" },
{ "command": "paste", "keys": "ctrl+v" }

@DHowett
Copy link
Member

DHowett commented Nov 25, 2020

Right: we bound ctrl+c by default only for users who installed after... maybe 0.7? 0.5? So we didn’t mess up everyone who installed before then.

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 25, 2020
@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Nov 29, 2020
@ghost
Copy link

ghost commented Nov 29, 2020

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost ghost closed this as completed Dec 2, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity.
Projects
None yet
Development

No branches or pull requests

3 participants