Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official Ubuntu theme for theme marketplace #8058

Closed
sirredbeard opened this issue Oct 27, 2020 · 10 comments
Closed

Official Ubuntu theme for theme marketplace #8058

sirredbeard opened this issue Oct 27, 2020 · 10 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@sirredbeard
Copy link

This is a feature request for an official Ubuntu theme in the Windows Terminal theme gallery, which is currently priority 2 on the roadmap for Windows Terminal 2.0.

We would like to engage with our Design Team at Canonical to develop a delightful theme for users using all available and planned theme features to be available when the theme gallery launches.

A concept:

image

@sirredbeard sirredbeard added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 27, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 27, 2020
@zadjii-msft
Copy link
Member

@sirredbeard have you been in contact with @cinnamon-msft? I'm pretty sure the whole reason we're jumping on the proto-extensions thing (#7632) is so that Canonical can ship customizations for the Ubuntu distros that we auto detect.

@cinnamon-msft
Copy link
Contributor

Hey @sirredbeard, we're shipping proto-extensions in our next release, which will let Ubuntu ship their own Terminal theme inside the Ubuntu package. Does this work as a solution for you? We have a loose timeline for the theme marketplace.

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. labels Oct 27, 2020
@DHowett
Copy link
Member

DHowett commented Oct 27, 2020

@sirredbeard we’d love your feedback on fragment extensions (#7584).

@ghost
Copy link

ghost commented Oct 28, 2020

Will these extensions work on imported Ubuntu profiles?

@zadjii-msft
Copy link
Member

zadjii-msft commented Oct 28, 2020

Yep! Something like

{
    "profiles": [
        {
			// This is the GUID for Ubuntu-18.04
            "updates" : "{c6eaf9f4-32a7-5fdc-b5cf-066e8a4b1e40}",

            "background" : "#2C001E",
            "useAcrylic" : true,
            "acrylicOpacity" : 0.9,
            "icon" : "C:\\path\\to\\ubuntu-icon.png",
            "padding" : "4",
            "cursorColor" : "#FFaf00",
            "fontFace" : "Ubuntu Mono",
            "fontSize" : 14,
            "cursorShape" : "emptyBox"
        }
    ]
}

Would modify the auto-generated "Ubuntu-18.04" profile, so Canonical can change the appearance of distros that we auto-detect.

@sirredbeard
Copy link
Author

Does this work as a solution for you?

Yes, it does. I will get with Patrick on WSL to talk about ways we could integrate it into our Store app.

I will also highlight this for the Multipass team.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Oct 29, 2020
@sirredbeard
Copy link
Author

Being able to declare an extension and bundle the assets in the UWP app is going to be super helpful for us through the Store. Very excited about this.

@zadjii-msft
Copy link
Member

Okay thanks for confirming! I'm gonna call this a dupe of proto-extensions / "settings fragments" for now, I'd go follow those issues/PRs for updates.

/dup #1690
/dup #7632

Thanks!

@ghost
Copy link

ghost commented Nov 2, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 2, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements Needs-Attention The core contributors need to come back around and look at this ASAP. labels Nov 2, 2020
@sirredbeard
Copy link
Author

That is fine. This was intended to just be a placeholder for the theme marketplace feature which was suggested we file but I will defer to your team.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants