Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the "windows menu" key for shortcuts #7270

Closed
jtnord opened this issue Aug 13, 2020 · 5 comments
Closed

Add support for the "windows menu" key for shortcuts #7270

jtnord opened this issue Aug 13, 2020 · 5 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@jtnord
Copy link

jtnord commented Aug 13, 2020

Add support for the "windows menu" key for shortcuts

#6635 introduced the commandPalette command. I would really like to be able to bind this to the "windows menu key" however this does not seem to be possible.

Either it is possible and the keyname is not documented, or the documentation is correct and this is not possible.

As a user I expect to be able to use any key on my keyboard in order to bind commands (including keys that may be special for example some extended MS keyboards with a calculator button) by specifiying a keycode if required and the key does not have a common name.

Proposed technical implementation details (optional)
@jtnord jtnord added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 13, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 13, 2020
@zadjii-msft
Copy link
Member

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #3184 for more discussion.

/dup #3184

@ghost
Copy link

ghost commented Aug 13, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Aug 13, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 13, 2020
@jtnord
Copy link
Author

jtnord commented Aug 26, 2020 •
edited
Loading

@zadjii-msft is this a duplicate? on reading #3184 it seems to only be talking about the winkey and it appears there may be issues with that. here I am talking about the win-menu (on the right in the following image)

image

happy if they are to be handled together that they are merged but it sounded like technically there may be issued to do so.

@jtnord
Copy link
Author

jtnord commented Nov 4, 2020 •
edited
Loading

incorrect dupe - more likely #7144 now implemented

@zadjii-msft
Copy link
Member

Yes - you're right about that. My bad for not catching the difference earlier!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtnord @zadjii-msft