Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically switch between dark and light themes based on global operating system dark/light setting #6658

Closed
cdmihai opened this issue Jun 24, 2020 · 2 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@cdmihai
Copy link

cdmihai commented Jun 24, 2020

Description of the new feature/enhancement

To reduce eye strain, add a feature to Terminal to automatically change themes based on the global operating system dark/light theme setting.
Right now this is tedious and time consuming to do in Terminal, as it requires the user to manually edit the settings.json and alternate between two themes.

Working with a dark theme in a strongly lit environment, or with a light theme in a gloomy/dark environment puts a lot of strain on my eyes, as I have to squint a lot. Ideally I'd want dark themes on all the OS apps in dark environments, and light themes on all the OS apps in light environments.
Most of the places I work at transition from strong light to gloom throughout the day. I manually transition everything from dark to light and vice versa, as the light changes. This is tedious and time consuming, as very few apps change their theme based on the global OS setting. I change the OS, and then manually change VSCode, Visual Studio, Terminal, and Teams. It would be awesome if all of these automatically changed based on the OS, including Terminal.

Proposed technical implementation details (optional)

Introduce another setting that chooses between two themes, based on the OS settings:

"switch.themes.based.on.os": "true",
"light.os.theme": "One Half Light",
"dark.os.theme": "Campbell"
@cdmihai cdmihai added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 24, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 24, 2020
@cdmihai cdmihai changed the title Automatically switch to dark or light themes based on global operating system dark/light setting Automatically switch between dark and light themes based on global operating system dark/light setting Jun 24, 2020
@DHowett
Copy link
Member

DHowett commented Jun 24, 2020

Thanks for the request! This is being tracked in /dup #6491.

@ghost
Copy link

ghost commented Jun 24, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jun 24, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 24, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants