Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring "Open in Windows Terminal" for Right Click on Drive Letter #6654

Open
MikeMcCollister opened this issue Jun 24, 2020 · 14 comments
Open
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone

Comments

@MikeMcCollister
Copy link

Description of the new feature/enhancement

Bring "Open in Windows Terminal" for right click on drive letter. In Windows Terminal 1.1.1671.0 I am able to do this on a folder but it does not work on a drive letter.

@MikeMcCollister MikeMcCollister added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 24, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 24, 2020
@zadjii-msft zadjii-msft added Area-ShellExtension For issues related to the explorer right-click context menu Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jun 24, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 24, 2020
@zadjii-msft
Copy link
Member

I'm not sure if this is caused by the same thing as #6414 or not.

@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Jun 24, 2020
@MikeMcCollister
Copy link
Author

I'm glad your tracking that issue as well (#6414). I was about report that.

@DHowett
Copy link
Member

DHowett commented Jun 24, 2020

No no, this is the exact same thing. /dup #6414

@ghost
Copy link

ghost commented Jun 24, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jun 24, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 24, 2020
@DHowett
Copy link
Member

DHowett commented Jun 24, 2020

That should teach me to read. It probably isn't the same.

@DHowett DHowett reopened this Jun 24, 2020
@DHowett DHowett removed the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jun 24, 2020
@MikeMcCollister
Copy link
Author

I'm now using version 1.6.10571.0 of Windows Terminal. There still is no right click on the drive letter to "Open in Windows Terminal". I can, however, right click on a white area in any folder and "Open in Windows Terminal" is available.

After reading this thread, I'm confused on whether this is a duplicate of another issue. When I searched around, I came right back to this one.

@zadjii-msft
Copy link
Member

Heck, I think even Dustin is confused 😆

image

I think this is a unique enough issue. I'm not sure how we attach to the context menu for a drive (not just a folder), but there's gotta be a way.

@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Mar 3, 2021
@MikeMcCollister
Copy link
Author

Yep, there has to be a way. With a shift right click there is an "Open PowerShell window here" and on a regular right click there is an "Open with Code" item.

@zadjii-msft
Copy link
Member

This is being tracked internally with MSFT:32135340 (I think?)

@DHowett
Copy link
Member

DHowett commented Mar 15, 2021

(It cannot be done with packaged COM today. Yeah.)

@zadjii-msft
Copy link
Member

@zadjii-msft
Copy link
Member

Ah. So, I'll need to wait for the SV2 SDK to use this then presumably? I just tried adding this to the Terminal (built on the 22000 SDK) and it gave me the classic APPX0501 error.

                <desktop5:ItemType Type="Drive">
                    <desktop5:Verb Id="OpenTerminalDev" Clsid="52065414-e077-47ec-a3ac-1cc5455e1b54" />
                </desktop5:ItemType>

Also, will this just gracefully continue to do nothing on Windows 10?

(I also just tried this with desktop10:ItemType but got something about The schema for MaxVersionTested specified does not recognize XML fields with namespace "http://schemas.microsoft.com/appx/manifest/desktop/windows10/10".)

right, I think it is available in the {SV2} SDK. I think one of them either Drive or DesktopBackground will just work in SV1. I'm not sure about what will happen on Windows 10.

Okay, so if we target the sv2 sdk, this might just work today, but we really really need to confirm on Windows 10 manually.

@nhchmg
Copy link

nhchmg commented Apr 14, 2023

Ah. So, I'll need to wait for the SV2 SDK to use this then presumably? I just tried adding this to the Terminal (built on the 22000 SDK) and it gave me the classic APPX0501 error.

                <desktop5:ItemType Type="Drive">
                    <desktop5:Verb Id="OpenTerminalDev" Clsid="52065414-e077-47ec-a3ac-1cc5455e1b54" />
                </desktop5:ItemType>

Also, will this just gracefully continue to do nothing on Windows 10?
(I also just tried this with desktop10:ItemType but got something about The schema for MaxVersionTested specified does not recognize XML fields with namespace "http://schemas.microsoft.com/appx/manifest/desktop/windows10/10".)

right, I think it is available in the {SV2} SDK. I think one of them either Drive or DesktopBackground will just work in SV1. I'm not sure about what will happen on Windows 10.

Okay, so if we target the sv2 sdk, this might just work today, but we really really need to confirm on Windows 10 manually.

What is sv2 sdk? does support Type="Drive" now? please tell me,thank you.

@AndromedaMelody
Copy link

AndromedaMelody commented Jun 8, 2023

@nhchmg sv2 sdk in appx/msix packaging is Microsoft.Windows.SDK.BuildTools (Version 10.0.22621.*). Until now desktop10:ItemType is an undocumented property. We have tried to add it in M2Team/NanaZip#313 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

6 participants
@DHowett @nhchmg @zadjii-msft @AndromedaMelody @MikeMcCollister and others