Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find with color highlights and find with regrex match support #6509

Closed
lpstudy opened this issue Jun 15, 2020 · 2 comments
Closed

Find with color highlights and find with regrex match support #6509

lpstudy opened this issue Jun 15, 2020 · 2 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@lpstudy
Copy link

lpstudy commented Jun 15, 2020

Description of the new feature/enhancement

  1. Currently, to find the text in terminal, it only highlights only one that matches. Do we consider to highlights all the matched texts?

  2. Currently find do not support regrex expression, do we consider to support it?

  3. Bug report
    Current find dialog in one panel does not disappear even I change the focus to other panels. This may lead to ESC does not work for closing find dialog.

Proposed technical implementation details (optional)

image
@lpstudy lpstudy added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 15, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 15, 2020
@zadjii-msft
Copy link
Member

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #3920 for more discussion.

/dup #3920

@ghost
Copy link

ghost commented Jun 15, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jun 15, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 15, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpstudy @zadjii-msft