-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closeTab should present a confirmation dialog #5301
Comments
I'd suggest to have this user-configurable so that you could have both a close-without-confirmation command and a close-with-confirmation one and bind them to separate keybinds if you like (e.g. with the latter command bound to combo less fat-finger prone) |
I had the same request in the linked issue. One suggestion I'd like to mention here is that you should ask the user what to do instead of simply warning the user. ExampleTab with split-pane: powershell | cmd
|
Please also make it possible to show a warning on simple tab closing, not only with multiple panes. |
Yep, I'm pretty sure that's tracked as a part of #6549 (comment). |
Same here, I just misclicked and lost one of my tabs with an active SSH connection and ongoing work. |
Description of the new feature/enhancement
closeTab
should present a confirmation dialog if multiple panes are open. This would prevent users from accidentally closing all panes in a tab by accident.The text was updated successfully, but these errors were encountered: