Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflow with long input loses cursor #4955

Closed
carlos-zamora opened this issue Mar 17, 2020 · 7 comments
Closed

Reflow with long input loses cursor #4955

carlos-zamora opened this issue Mar 17, 2020 · 7 comments
Assignees
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Conpty For console issues specifically related to conpty Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely.
Milestone

Comments

@carlos-zamora
Copy link
Member

Environment

Windows Terminal version (if applicable) :0.10.721.0

Any other software?

Steps to reproduce

Not too sure what caused it but I know I have a really long path in the prompt. It's fine when I interact with it at first. But after attempting to run the command, and pasting the same path again, the cursor goes crazy. Specifically, I was ctrl+left and it started happening. Here's a gif:

  1. paste long path/command
  2. run it (mine failed, derp)
  3. press up (populates prompt)
  4. ctrl+left to browse the input

Actual behavior

cursor goes wack

reflow bug

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 17, 2020
@carlos-zamora
Copy link
Member Author

@zadjii-msft Thoughts?

@DHowett-MSFT
Copy link
Contributor

This may be a combination of the perfect wrap bug and this issue where sometimes the conpty host is off by one width

@zadjii-msft
Copy link
Member

GAH I don't know what this is but I'll put it on me

@zadjii-msft zadjii-msft self-assigned this Mar 17, 2020
@zadjii-msft zadjii-msft added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Conpty For console issues specifically related to conpty Product-Terminal The new Windows Terminal. labels Mar 17, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 17, 2020
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Mar 17, 2020
@zadjii-msft
Copy link
Member

@carlos-zamora what's your prompt set to in powershell? I can't get this to repro with

$esc = [char]27; function prompt() { "${esc}[41mhas a newline${esc}[m`n${esc}[33;40mha ha ha${esc}[m> " }

Was there any actual resizing involved?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. labels Mar 17, 2020
@carlos-zamora
Copy link
Member Author

@carlos-zamora what's your prompt set to in powershell? I can't get this to repro with

$esc = [char]27; function prompt() { "${esc}[41mhas a newline${esc}[m`n${esc}[33;40mha ha ha${esc}[m> " }

Was there any actual resizing involved?

I guess it's just a reflow bug, not resize.

I have a custom prompt, but it's basically just the Powerline theme from oh-my-posh. I'm wondering if this is just another manifestation of #2432?

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 17, 2020
@zadjii-msft
Copy link
Member

I mean, I'm sure it's possible, though that one I'm positive that conpty and Terminal have the same contents in the buffer, while this one I'm a little more scared. I'll try oh-my-posh and see if that repros it for me.

@carlos-zamora
Copy link
Member Author

Ok. We somehow couldn't get a repro of this. We're thinking it might be a powerline issue? But we're just gonna close this out until it pops up again. Spooky

@zadjii-msft zadjii-msft added Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Conpty For console issues specifically related to conpty Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely.
Projects
None yet
Development

No branches or pull requests

3 participants