Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode observations on stdin & stdout #3786

Closed
sipsorcery opened this issue Nov 30, 2019 · 4 comments
Closed

Unicode observations on stdin & stdout #3786

sipsorcery opened this issue Nov 30, 2019 · 4 comments
Assignees
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@sipsorcery
Copy link

It's nice to see that unicode handling on stdin and stdout is improving from the old Windows Console.

The tests below were done using:

  • Windows 10 Pro 10.0.1.19033 Build 19033
  • Windows Terminal Preview v0.7.3291.0
  • Font: cascadia

The test steps were:

  1. Paste Run🏃 to the command prompt,
  2. Hit Enter
  3. Press the Up Arrow

cmd_run

ps_run

wsl_run

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 30, 2019
@j4james
Copy link
Collaborator

j4james commented Nov 30, 2019

I suspect there may be two separate issues here, because each shell has its own command line editor. For PowerShell, this problem was previously reported in issue #1503. For the cmd shell, I think it's a limitation of the COOKED_READ implementation, and the way it handles surrogate pairs. I couldn't find an existing issue for that, but it's possible it could be addressed by #780.

@DHowett-MSFT DHowett-MSFT self-assigned this Dec 2, 2019
@DHowett-MSFT
Copy link
Contributor

I'm taking the baton here to find the dupes. Thanks @j4james for 1503. 😄

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 5, 2019
@DHowett DHowett assigned DHowett and unassigned DHowett-MSFT May 17, 2020
@zadjii-msft
Copy link
Member

You know, he never did find those dupes 😛

I'll go with #1503 since that's basically the root cause here. Thanks! /dup #1503

@ghost
Copy link

ghost commented Dec 9, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Dec 9, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Tag-Fix Doesn't match tag requirements labels Dec 9, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

5 participants