[Megathread] Fullscreen & Focus Mode follow-up work

[zadjii-msft]

Taken from #531 (comment)

I'd suggest that this is broken into 3 implementation steps:

1. Support fullscreen mode, with always hidden tabs
2. Add a setting to have tabs always visible in fullscreen mode
3. Enable "revealing" tabs on mouse hover near the top

Step 3 has some implementation details that are missing, like: on tabs reveal, should the tabs:

• cover the terminal content, obscuring the top rows, but leaving the rest of the window unchanged
• cause the terminal to resize
• shift the terminal content down, obscuring the bottom rows of the terminal, but not forcing a resize?

Now that #3408 is merged (closing #531), we need some place to track the follow-up tasks I had outlined before:

Focus mode and Fullscreen share a lot of commonalities, so I'm grouping them into one thread for easy of x-linking.

Fullscreen

• Support fullscreen mode, with always hidden tabs
• No tabs in fullscreen, focus mode or not #11130 - Add a setting to have tabs always visible in fullscreen mode
  • "showTabsInFullscreen": true|"always"
• Fullscreen: enable revealing the tabs by hovering at the top of the screen #5677 - Enable "revealing" tabs on mouse hover near the top
  • "showTabsInFullscreen": "hover"
• If a launch full screen option is there, when the full screened app launches, I think the TabView should be visible for a few seconds before sliding out of view. (from @mdtuak in [Setting] Option to launch already maximized / fullscreen #288 (comment))
  • this is dependent upon adding fullscreen to launchMode, tracked in [Setting] Option to launch already maximized / fullscreen #288
• Scenario: Add support for 3rd-party extensions #4000 It would be nice to have a kind of popup with a tab name when you switch tabs with CTRL+TAB in fullscreen mode.
  • Let's add a setting for this as well, this sounds like a not so terrible idea.
  • This is the "advanced tab switcher"

Focus Mode

• Feature Request: Ctrl-Drag anywhere on the terminal window to move the window #539
  • Not necessarily Focus Mode related, but certainly relevant
• Launching in Focus mode doesn't start at the correct size #10730
• Add a mode where alwaysShowTabs=false *and* there is no titlebar (like focus) #7210
• White line at bottom when using "Automatically hide the taskbar" #12959

[nathpete-msft]

@zadjii-msft, as part of step 2, could that setting also have an option to only show tabs in fullscreen if there is currently more than one tab? Or would that setting just also take into account the existing alwaysShowTabs setting? The latter is how iTerm handles this, and I think feels pretty natural.

In that case, these settings might behave together like so:

State	2+ Tabs	Always Show Tabs	Show Tabs In Fullscreen	Tabs Visible
Windowed	Yes	Yes	N/A	Yes
Windowed	Yes	No	N/A	Yes
Windowed	No	Yes	N/A	Yes
Windowed	No	No	N/A	No
Fullscreen	Yes	Yes	Yes	Yes
Fullscreen	Yes	Yes	No	No
Fullscreen	Yes	No	Yes	Yes
Fullscreen	Yes	No	No	No
Fullscreen	No	Yes	Yes	Yes
Fullscreen	No	Yes	No	No
Fullscreen	No	No	Yes	No
Fullscreen	No	No	No	No

[zadjii-msft]

@nathpete-msft That seems pretty reasonable to me. If that's how iTerm2 does it, then that's a pretty good precedent.

[dominik-ba]

I would love to have step 2 implemented. Especially if you have windows terminal in a second desktop you can simply switch to a fullscreen terminal with win + cmd + left/right. I know this works alreday but not knowing which tabs are open and which one I am using is a bit of a hassle.
That would be awesome! :)
Any plans on when this will get implemented?

PS: Now that I check on some more issues in this repo I'm confused since quite some people created (duplicate) issues about the padding of the tabs in fullscreen mode but I checked again and did not find a way or documentation how to enable this. Is this PR old or are those people not acutually talking about fullscreen?

[zadjii-msft]

@dominik-ba This work is not currently on any particular milestone. I can guarantee that it's not making the cut for 1.0, since we're currently in a feature-freeze as we prepare to release 1.0.

I think some of the other issues you're referring too mainly mean "maximized" when they're saying "fullscreen"

[dominik-ba]

Wouldn't it be relatively easy to enable th new toggle focus feature also on fullscreen?
This would check step 2 :)

[GeekJosh]

Just for visibility, I have opened a PR to address #11130 (no tabs in fullscreen): #18171

I really like the idea of #5677 (show tabs on hover), so once a decision is made on my current PR (adding the simpler true/false setting), I'm happy to take a look at implementing that next. As TabView doesn't currently support a "reveal on hover" setting, my initial thought would be to use to a Flyout to achieve that effect, though I will admit I don't have a huge amount of experience with WinUI so if that is a bad idea I'm open to looking in to alternative implementations if anyone has any suggestions?