Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-profile wordCharacters #3078

Open
egmontkob opened this issue Oct 5, 2019 · 1 comment
Open

Per-profile wordCharacters #3078

egmontkob opened this issue Oct 5, 2019 · 1 comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@egmontkob
Copy link

Description of the new feature/enhancement

"wordDelimiters" is a global config option rather than a per-profile one, although there's nothing in this option that inherently has to make it a global one.

In gnome-terminal we had quite a lot of debates around which character should be included and which not. The biggest debate was around :. Folks working with URLs or timestamps want colons to be word characters. Folks working with e.g. grep or compiler outputs (such as filename:matching_content or filename:line_number want the colon to be a stop character.

I can easily imagine that some users would prefer to have different profiles with different double click behaviors, depending on the kind of task they're working on.

Could you guys consider moving it to a per-profile option? Although then it's a bit of maintenance burden when someone wants to update the set and has to do for all the profiles. Feel free to close this bug if it was a deliberate choice from you to make it global.

(On a side note, the same question could also be asked for "copyOnSelect" I guess...?? I'm not sure about that, my gut feelings tell me it's better to have an overall consistent experience here, just as you don't want to have different "keybindings" per profile, but again, these are just feelings.)

@egmontkob egmontkob added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 5, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 5, 2019
@carlos-zamora carlos-zamora added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Oct 7, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 7, 2019
@zadjii-msft
Copy link
Member

I definitely agree that there's nothing that inherently makes this a global setting. It could certainly be a per-profile setting.

Maybe this is something that would be made easier with #2325, so the "global profile defaults" would have the default settings we provide, and then users could update it per-profile if they wanted.

I concur that copyOnSelect could definitely fit into that category of settings as well.

@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Oct 24, 2019
@zadjii-msft zadjii-msft added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Oct 24, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 29, 2019
@cinnamon-msft cinnamon-msft added v1-Scrubbed Help Wanted We encourage anyone to jump in on these. labels Jan 23, 2020
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

6 participants