Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: "Paste" should focus and paste #2444

Closed
flindeberg opened this issue Aug 15, 2019 · 3 comments
Closed

Feature Request: "Paste" should focus and paste #2444

flindeberg opened this issue Aug 15, 2019 · 3 comments
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.x

Comments

@flindeberg
Copy link

Description of the new feature/enhancement

Using the mouse paste mechanism (regardless of right mouse, middle mouse or whatever mouse) on an unfocused terminal window / split-pane should focus and paste. Currently it focuses on windows and does nothing on panes.

Paste in window is currently: right click (or well, left click works as well for focus) + right click. Paste in split-panes is: left click + right click.

I only want to click once (regardless of middle mouse or right mouse or doing a rain dance in front of the camera) and not several times to paste text.

Also belong together with #524 function and use wise, since no-click-copy and single-click-paste are two of the best mechanisms out there 👍

Proposed technical implementation details (optional)

I haven't looked at the cose base, but I imaging it is a case of looking at how mouse-events are handled in focused contra unfocused windows and split-panes.
@flindeberg flindeberg added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 15, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 15, 2019
@flindeberg flindeberg mentioned this issue Aug 15, 2019
Closed
@DHowett-MSFT DHowett-MSFT added Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-User Interface Issues pertaining to the user interface of the Console or Terminal and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 19, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 19, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Aug 19, 2019
@richardszalay
Copy link
Contributor

Related: You cannot copy text from an unfocused pane without first focusing it. If you try, nothing happens.

(I would think that both these issues could potentially be resolved by focusing on mousedown rather than click)

@cinnamon-msft cinnamon-msft added the Priority-3 A description (P3) label Jan 23, 2020
@carlos-zamora
Copy link
Member

This got fixed. I have no idea when though. I recall working with @leonMSFT on this back when we were at the office.

I can't seem to find the PR that actually fixed it though.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 12, 2020
@carlos-zamora
Copy link
Member

Leon found it: #4506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.x
Development

No branches or pull requests
5 participants
@richardszalay @carlos-zamora @flindeberg @DHowett-MSFT @cinnamon-msft