Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to revert to old alpha-based selection colors #17837

Open
MatejKafka opened this issue Aug 31, 2024 · 1 comment
Open

Add an option to revert to old alpha-based selection colors #17837

MatejKafka opened this issue Aug 31, 2024 · 1 comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.

Comments

@MatejKafka
Copy link

In v1.22, selection colors were changed significantly to make the selection have uniform foreground and background color. However, the new colors are imo hard to read due to excessive contrast and they interact poorly with text with varying background and foreground color (see image 4 and 5). Also, using glyphs to create rounded corners on blocks with different background colors breaks with the new selection behavior (see image 3).

Personally, I much prefer the previous alpha-based selection. Could you add an option to revert to the previous behavior?

v1.21, the pretty alpha-based selection:
image

v1.22, too much contrast, imo does not look as good:
image


Bad rendering for rounded corners using glyphs:
image


v1.22 hides all background colors:
image

v1.21 preserves background colors, which imo looks better:
image

@MatejKafka MatejKafka added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 31, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 31, 2024
@zadjii-msft zadjii-msft added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Sep 3, 2024
@zadjii-msft zadjii-msft added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Sep 3, 2024
@zadjii-msft zadjii-msft added this to the Backlog milestone Sep 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 3, 2024
@carlos-zamora carlos-zamora modified the milestones: Backlog, Terminal v1.24 Sep 4, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants