Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed input is sometimes wrongly ordered #17825

Open
Vampire opened this issue Aug 29, 2024 · 3 comments
Open

Typed input is sometimes wrongly ordered #17825

Vampire opened this issue Aug 29, 2024 · 3 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@Vampire
Copy link

Vampire commented Aug 29, 2024

Windows Terminal version

1.20.11781.0

Windows build number

10.0.19045.3930

Other Software

Bash from Git for Windows

Steps to reproduce

I cannot tell exactly how to reproduce.
But it happens regularly.
The prompt is not ready yet because it still executes the last command or evaluates the PROMPT_COMMAND of Bash.
Then I already type the next command like git b -a (b here is a Git alias for branch -vv).

Now regularly it happens that once the prompt is ready what is inserted is misordered, like agit b -, so the characters typed later are input before characters typed earlier.

I first thought I just mistyped, but I'm absolutely sure now, that I did not mistype, but the characters were not inserted in the order I typed them.
I guess there is some race condition somewhere that causes this.

Expected Behavior

Input appears in the order I typed it.

Actual Behavior

Input is mixed up.

@Vampire Vampire added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 29, 2024
@zadjii-msft
Copy link
Member

  • Does this repro outside of Git for Windows?
  • Did this repro on older versions of the Terminal?
  • What version of git for windows / bash/?

Our current hypothesis is that this is something weird that cygwin is doing, but it's hard/impossible for us to investigate without a more consistent repro

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 4, 2024
@Vampire
Copy link
Author

Vampire commented Sep 4, 2024

Does this repro outside of Git for Windows?

I almost exclusively use Bash from Git for Windows as shell, so I don't know.

Did this repro on older versions of the Terminal?

I'm not 100% sure, but if it happened, then not that often that I felt like reporting it and I'm usually fast with reporting issues.

What version of git for windows / bash/?

Just updated 2 hours ago to 2.46.0.windows.1, I think it was 2.45.0.windows.1 before.
as I just upgraded it and did not do much work since then, I don't yet know whether it still reproduces.

Our current hypothesis is that this is something weird that cygwin is doing,

That's quite unlikely, as Cygwin is not at all involved. :-D
Git for Windows is MSYS-based, not Cygwin-based. :-)

it's hard/impossible for us to investigate without a more consistent repro

Totally understand that, I'm just not able to provide a better or more reliable reproduction recipe for this. :-(

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 4, 2024
@DHowett
Copy link
Member

DHowett commented Sep 5, 2024

Git for Windows is MSYS-based, not Cygwin-based. :-)

Ah, but MSYS is itself Cygwin-based! 🙂

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

3 participants