Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dim terminal when app terminates #17780

Open
elad-eyal-ns opened this issue Aug 22, 2024 · 4 comments
Open

Dim terminal when app terminates #17780

elad-eyal-ns opened this issue Aug 22, 2024 · 4 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@elad-eyal-ns
Copy link

I have a profile which is used for SSH. When the connection is lost, I get a message saying the process has terminated and I am to press ENTER to restart. It's not always easy to spot this message, since it can appear at the top or middle of the screen (wherever the cursor happened to be). I propose that at this time (optionally) dim the entire window. This way it will be easier to notice the app termination and hit ENTER before continuing.

@elad-eyal-ns elad-eyal-ns added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 22, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Sep 4, 2024
@carlos-zamora carlos-zamora added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 4, 2024
@zadjii-msft zadjii-msft modified the milestones: Backlog, Icebox ❄ Sep 4, 2024
@DHowett
Copy link
Member

DHowett commented Sep 4, 2024

Thanks for the request! For what it's worth... we have another visual indicator that the connection has been broken:

Image

We're not likely to prioritize the "appearance matrix" work required to support the combinations of {terminated/running, admin/non-admin, focused/unfocused} required to make this possible, so we're committing it to the distant distant backlog for now.

@zadjii-msft
Copy link
Member

and my stupid idea from triage:

  • connection dead? ---> deadConnectionAppearance
  • alive?
    • unfocused? ---> unfocusedAppearance
    • focused?
      • admin? ---> adminAppearance
      • standard ---> defaultAppearance

@elad-eyal
Copy link

Thanks for the request! For what it's worth... we have another visual indicator that the connection has been broken:

Image

what is "another visual indicator" ? the two lines of text? when using ssh and tmux they tend to appear anywhere on screen, hiding between whatever text happens to be on screen. it is not as clear as in the demo image you placed.

@DHowett
Copy link
Member

DHowett commented Sep 5, 2024

Good point.

It’s the (x) which appears to the left of the title. It’s visible in the tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

5 participants