Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action ID is missing from schema #17122

Closed
carlos-zamora opened this issue Apr 24, 2024 · 2 comments · Fixed by #17146
Closed

Action ID is missing from schema #17122

carlos-zamora opened this issue Apr 24, 2024 · 2 comments · Fixed by #17146
Assignees
@PankajBhojwani
Labels
Area-Schema Things that have to do with the json schema. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.21

Comments

@carlos-zamora
Copy link
Member

carlos-zamora commented Apr 24, 2024 •
edited
Loading

image
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Schema Things that have to do with the json schema. labels Apr 24, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.21 milestone Apr 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed this from the Terminal v1.21 milestone Apr 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 24, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hi! Thanks for attempting to open an issue. Unfortunately, you didn't write anything in the body which makes it impossible to understand your concern. You are welcome to fix up the issue and try again by opening another issue with the body filled out.

@DHowett DHowett reopened this Apr 24, 2024
@zadjii-msft zadjii-msft removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 26, 2024
@zadjii-msft zadjii-msft added this to the Terminal v1.21 milestone Apr 26, 2024
@zadjii-msft
Copy link
Member

@PankajBhojwani you decide if you want to put it in the schema for 1.21 even if we're not serializing them out after #17109

@PankajBhojwani PankajBhojwani mentioned this issue Apr 26, 2024
Merged
4 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Schema Things that have to do with the json schema. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.21
Development

Successfully merging a pull request may close this issue.

Add action ID to schema microsoft/terminal
4 participants
@DHowett @carlos-zamora @zadjii-msft @PankajBhojwani