Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panes should be resizable with the mouse #992

Open
zadjii-msft opened this issue May 24, 2019 · 11 comments · May be fixed by #16895
Open

Panes should be resizable with the mouse #992

zadjii-msft opened this issue May 24, 2019 · 11 comments · May be fixed by #16895
Assignees
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented May 24, 2019

Probably depends on #991 getting done first

Drag a separator to (recursively) resize the panes that are separated by that separator.

@zadjii-msft zadjii-msft added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 24, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 24, 2019
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels May 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 24, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone May 24, 2019
@DHowett-MSFT DHowett-MSFT removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 24, 2019
@carlos-zamora
Copy link
Member

Assigning to myself for now. I imagine it won't be too difficult. If anybody would like to take a crack at it though, feel free to let me know and we could just do a handoff. 😊

@carlos-zamora carlos-zamora self-assigned this May 12, 2020
@jonasnordlund
Copy link

One idea I have would be to not even require a user to target a potentially thin separator, but while holding down Alt (to retain the theme with the pane key bindings) and dragging the mouse up and down over one horizontally split pane, resize that one height wise. And the same when moving the mouse left and right over a vertically split pane.

@moswald
Copy link
Member

moswald commented Nov 12, 2020

It would be nice if, while resizing, a percent or pixel adornment showed up that indicates the new sizes for both panes.

@wardboumans

This comment was marked as spam.

@zadjii-msft

This comment was marked as off-topic.

@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Sep 2, 2021
@zadjii-msft zadjii-msft added the Priority-2 A description (P2) label Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@mbalc

This comment was marked as spam.

@zadjii-msft
Copy link
Member Author

Yep, we haven't had a chance to loop back on this, though we'd love the the contribution if you're interested!

Note

Walkthrough

  • Last time I tried this was in main...dev/migrie/f/drag-panes. IIRC, there were some scaling issues with mouse drags in XAML islands back then. I think those are mostly resolved these days.
  • Carlos also tried this again in dev/cazamor/drag-panes. I don't know how successful that was.

I don't think it'd be terribly difficult to resurrect the same approach (but base it off main since my original branch is nearly 4 years old now.

@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog May 3, 2023
@davea38
Copy link

davea38 commented Sep 20, 2023

Massively agree with this new feature! Resizing via the keyboard is annoying. Also there are currently too many keyboard shortcuts to remember for an old man such as myself :>

@bradphelan
Copy link

bradphelan commented Jan 11, 2024

I think dragging the panes is the wrong UX. It's always a pain the try and get the tiny mouse sitting on the tiny drag bar. The alternative is to make the drag bar thicker and waste terminal space. I propose an alterative. We already have

to change the font size. If we add

and instead of changing font size, it resizes the pane. The location of the mouse itself gives the hint as to where to resize. left, right, up down.

This could easily be solved with a few more key modifiers. Unfortunately 'keys' don't include mouse modifiers.

image

If the keys could also handle mouse actions as well then the above could be implemented by the user.

@zadjii-msft zadjii-msft modified the milestones: Backlog, Terminal v1.21 Feb 22, 2024
@zadjii-msft zadjii-msft self-assigned this Feb 22, 2024
@zadjii-msft zadjii-msft linked a pull request Mar 27, 2024 that will close this issue
2 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Apr 3, 2024
@anashakt

This comment was marked as spam.

@DHowett
Copy link
Member

DHowett commented Aug 22, 2024

Punted to 1.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
Status: Walkthrough in issue
Development

Successfully merging a pull request may close this issue.