Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Protection #15777

Closed
majerus1223 opened this issue Jul 29, 2023 · 4 comments
Closed

Tab Protection #15777

majerus1223 opened this issue Jul 29, 2023 · 4 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@majerus1223
Copy link

Description of the new feature/enhancement

Tab Protection to keep long running processes, development scripts from being accidently closed via close all button within the terminal.

Proposed technical implementation details (optional)

When you right click the tab, you have an option to "Protect" , "Pin", "Guard" or something like that to the specific tab you have open.
If you click the right most X, on the terminal app close all non "Protected" tabs
Pop up a toast or message asking if you would like to close the protected tab and or if multiple tabs . (I would have two buttons one for single tab, one for all)

image

@majerus1223 majerus1223 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 29, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 29, 2023
@zadjii-msft
Copy link
Member

Would something like read-only mode work for you/? That's a bit more heavy handed - that disables closing AND input.

If not, then this should probably be duped to #6549 (which is broadly tracking all the combinations of "prompt me before I close a {{thing}}")

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 1, 2023
@majerus1223
Copy link
Author

The read only mode is interesting. I would say for now maybe #6549 makes some sense as its appear more like what I was shooting for.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 1, 2023
@zadjii-msft
Copy link
Member

Excellent, thanks!

/dup #6549

@microsoft-github-policy-service
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements Needs-Attention The core contributors need to come back around and look at this ASAP. labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants