Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal crashes after splitting panes - all profiles, orientations affected #15431

Closed
killshot13 opened this issue May 25, 2023 · 7 comments
Closed
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@killshot13
Copy link

killshot13 commented May 25, 2023

Windows Terminal version

1.18.1421.0

Windows build number

10.0.22624.0

Other Software

PowerShell 7.3.4
WSL2: 1.2.5.0
Ubuntu 22.04 LTS
Git for Windows v2.40.1

These are the underlying profiles from which I am attempting to generate the split-pane view.

Steps to reproduce

Easiest Steps:

  1. Open a Windows Terminal Preview tab.
  2. Right-click the tab and select Split Pane from the menu.
  3. Attempt to interact with the terminal or simply wait a few seconds, and it crashes.

Alternative Steps:

  1. Open a Windows Terminal Preview tab.
  2. Use the CTRL-SHIFT-P shortcut to focus the command menu dropdown.
  3. Type Split into the search to populate the relevant commands.
  4. Navigate to the Split Pane option and hit the Enter key.
  5. Attempt to interact with the terminal or simply wait a few seconds, and it crashes.

Expected Behavior

I expected to successfully create multiple panes within the terminal view, and for them to be swappable, movable, and able to be reoriented without affecting the performance of the interface or the shell.

Actual Behavior

I'm not entirely sure my if bug is the same as referenced in #14254 or #14247. But it's extremely similar. However this issue is distinctively broader, because it occurs regardless of which profile is being split and in what orientation. I've attached a short video so you can take a look, and the link to the Feedback Hub submission is down below. 👇


Windows_Terminal.2023-05-25_055718.mp4

Feedback Hub submission link

@killshot13 killshot13 added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 25, 2023
@sephiroth-j
Copy link

It happens also when you start a new instance of Windows Terminal Preview (e.g. from the context menu).

grafik

But the Windows Terminal Preview window stays open and is fully usable after closing the Windows dialog. An application error event is logged with the following data.

<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
	<System>
		<Provider Name="Application Error"/>
		<EventID Qualifiers="0">1000</EventID>
		<Version>0</Version>
		<Level>2</Level>
		<Task>100</Task>
		<Opcode>0</Opcode>
		<Keywords>0x80000000000000</Keywords>
		<TimeCreated SystemTime="2023-05-25T13:37:22.9375479Z"/>
		<EventRecordID>79999</EventRecordID>
		<Correlation/>
		<Execution ProcessID="0" ThreadID="0"/>
		<Channel>Application</Channel>
		<Computer>XXXX</Computer>
		<Security/>
	</System>
	<EventData>
		<Data>WindowsTerminal.exe</Data>
		<Data>1.18.2305.22001</Data>
		<Data>646c16cf</Data>
		<Data>ucrtbase.dll</Data>
		<Data>10.0.19041.789</Data>
		<Data>2bd748bf</Data>
		<Data>c0000409</Data>
		<Data>000000000007286e</Data>
		<Data>2b5c</Data>
		<Data>01d98f0dfd26c9b8</Data>
		<Data>C:\Program Files\WindowsApps\Microsoft.WindowsTerminalPreview_1.18.1421.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe</Data>
		<Data>C:\WINDOWS\System32\ucrtbase.dll</Data>
		<Data>a216b7cb-d516-4fb4-8aed-c5f9d5a4df08</Data>
		<Data>Microsoft.WindowsTerminalPreview_1.18.1421.0_x64__8wekyb3d8bbwe</Data>
		<Data>App</Data>
	</EventData>
</Event>

@zadjii-msft
Copy link
Member

Do you have focusFollowMouse enabled by any chance? Does disabling that setting fix this? (see #15412)

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 25, 2023
@evanjs
Copy link

evanjs commented May 25, 2023

Disabling focusFollowMouse appears to resolve the issue for me

@sephiroth-j
Copy link

Do you have focusFollowMouse enabled by any chance? Does disabling that setting fix this? (see #15412)

Disabling focusFollowMouse resolves the crash when splitting panes but not when starting another Terminal instance.

@zadjii-msft
Copy link
Member

@sephiroth-j You're on Windows 10, yea? My psychic debugging tells me that the crash when starting a second instance is #15410. That's based solely on the observation that the second windowsterminal.exe process crashes, but the first keeps running happily. I don't think there's a workaround for that one currently - though, we should have a hotfix for that soontm

@sephiroth-j
Copy link

@sephiroth-j You're on Windows 10, yea? My psychic debugging tells me that the crash when starting a second instance is #15410. That's based solely on the observation that the second windowsterminal.exe process crashes, but the first keeps running happily. I don't think there's a workaround for that one currently - though, we should have a hotfix for that soontm

Yes, version 10.0.19045.3031 to be precise. Thanks for pointing out issue #15410, I must have missed that. 🤷

@killshot13
Copy link
Author

killshot13 commented May 28, 2023

Do you have focusFollowMouse enabled by any chance? Does disabling that setting fix this? (see #15412)

Yes, I did, and yes, that resolved the issue. I am closing this issue since the root cause is already being tracked in #15420. Thank you, @zadjii-msft.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

4 participants