Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink settings grouping #1513

Closed
mcpiroman opened this issue Jun 24, 2019 · 1 comment
Closed

Rethink settings grouping #1513

mcpiroman opened this issue Jun 24, 2019 · 1 comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@mcpiroman
Copy link
Contributor

mcpiroman commented Jun 24, 2019 •
edited
Loading

Referencing #754 and #1448, I think it's best to abandon separation between global/profile settings. Instead each setting could go to anywhere, but with profile settings overwriting global ones. There still will need to be global-only settings like showTabsInTitlebar or defaultProfile, but others could be made available as per-profile (e.g. keybindings or initialCols).

Additionally, I suggest a 'property groups' - groups of settings that you can '#include' in profiles (like include: ["guid1", "guid2"]). E.g. you may want to have consistent settings between wsl distros and anothers between cmd/ps profiles. (I can easily imagine profiles that differ only in command line, starting path or something like this, but have other settings, mostly, shared.)

Issues:

  • How should default settings look (what goes where?)
  • Design of settings GUI that support this might be hard
@mcpiroman mcpiroman added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 24, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 24, 2019
@DHowett-MSFT
Copy link
Contributor

This'll probably be helped out a lot by #754 -- i'd like to hold off on further settings discussions until that one lands. We'd be happy to hear your settings feedback in 754 or on the spec review #1258.

@DHowett-MSFT DHowett-MSFT added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. labels Jun 27, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 27, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 27, 2019
@mcpiroman mcpiroman mentioned this issue Jun 28, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DHowett-MSFT @mcpiroman