-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typos #14670
Comments
noticed this looking at the initial patch the fix would be find a deserializer
|
Even though you've got one signoff on your PR (we require two per repository policy), you're of course free to continue submitting revisions to it. |
After a commit reverting the changes to the bundled
I used the same commit message as for the initial commit.
And then I force-pushed the changes.
I presume from your previous comment that the above commit was correct. I'll leave this for Members' consideration in another PR. #12475 left everytime in the allow list .github/actions/spelling/expect/expect.txt --- expect.txt.orig 2023-01-14 11:12:27.296971808 -0600
+++ expect.txt 2023-01-14 11:37:56.432957871 -0600
@@ -590,7 +590,6 @@
EUDC
EVENTID
eventing
-everytime
evflags
evt
execd
@@ -1550,7 +1549,6 @@
READCONSOLEOUTPUTSTRING
READMODE
reallocs
-reamapping
rects
redef
redefinable
@@ -2196,7 +2194,6 @@
WNegative
WNull
wnwb
-workarea
workaround
WOutside
WOWARM terminal/src/terminal/input/terminalInput.cpp the fix would be Vim without remapping
terminal/src/interactivity/win32/window.cpp the fixes would be monitor's work area it doesn't appear that WORKAREA is a variable; so should be rewritten in lowercase and as two words
|
If Members want to add the additional changes from the previous comment they are welcome to do so. .github/actions/spelling/expect/expect.txt terminal/src/terminal/input/terminalInput.cpp --- terminalInput.cpp.orig 2023-01-15 10:05:05.979936352 -0600
+++ terminalInput.cpp 2023-01-15 10:05:52.739935827 -0600
@@ -125,7 +125,7 @@
// The numpad has a variety of mappings, none of which seem standard or really configurable by the OS.
// See http://invisible-island.net/xterm/ctlseqs/ctlseqs.html#h2-PC-Style-Function-Keys
// to see just how convoluted this all is.
- // PuTTY uses a set of mappings that don't work in ViM without reamapping them back to the numpad
+ // PuTTY uses a set of mappings that don't work in Vim without remapping them back to the numpad
// (see http://vim.wikia.com/wiki/PuTTY_numeric_keypad_mappings#Comments)
// I think the best solution is to just not do any for the time being.
// Putty also provides configuration for choosing which of the 5 mappings it has through the settings, which is more work than we can manage now. terminal/src/interactivity/win32/window.cpp --- window.cpp.orig 2023-01-15 10:09:36.609933311 -0600
+++ window.cpp 2023-01-15 10:10:48.072932507 -0600
@@ -281,17 +281,17 @@
auto hMon = MonitorFromRect(rectProposed.as_win32_rect(), MONITOR_DEFAULTTONEAREST);
MONITORINFO mi = { 0 };
- //get origin of monitor's workarea
+ //get origin of monitor's work area
mi.cbSize = sizeof(MONITORINFO);
GetMonitorInfo(hMon, &mi);
- //Adjust right and bottom to new positions, relative to monitor workarea's origin
+ //Adjust right and bottom to new positions, relative to monitor work area's origin
//Need to do this before adjusting left/top so RECT_* calculations are correct
rectProposed.right = mi.rcWork.left + rectProposed.width();
rectProposed.bottom = mi.rcWork.top + rectProposed.height();
// Move origin to top left of nearest
- // monitor's WORKAREA (accounting for taskbar
+ // monitor's work area (accounting for taskbar
// and any app toolbars)
rectProposed.left = mi.rcWork.left;
rectProposed.top = mi.rcWork.top; |
code comments
Coincidentally
hasn't
marshaller
marshal
preceding
process
markdown
every time
foresee
.github/actions/spelling/expect/expect.txt
As pointed out in a previous PR 'everytime' doesn't belong in expect.txt.
The text was updated successfully, but these errors were encountered: