Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering bug with icons wider than one column (gap in background) #13700

Closed
ghillb opened this issue Aug 8, 2022 · 1 comment · Fixed by #14959
Closed

Rendering bug with icons wider than one column (gap in background) #13700

ghillb opened this issue Aug 8, 2022 · 1 comment · Fixed by #14959
Assignees
@lhecker
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal.

Comments

@ghillb
Copy link

ghillb commented Aug 8, 2022

Windows Terminal version

1.14.1962.0

Windows build number

10.0.19044.1826

Other Software

  • WSL Ubuntu 22.04
  • nvim 0.7.2,
  • FiraCode Retina NerdFont.
  • lualine nvim plugin (example appears anywhere where an icon is rendered in front of solid background)

Steps to reproduce

Expected Behavior

No gap in rendering

alacritty (windows) or kitty (ubuntu), do not have this issue with the same font:
image

Actual Behavior

Gap in background highlight rendering, when icons wider than 1 column (e.g., xml file icon in nerd fonts) are rendered.

ms-terminal:
image

more info:
nvim-lualine/lualine.nvim#790
@ghillb ghillb added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Aug 8, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 8, 2022
@zadjii-msft
Copy link
Member

This might be fixed by the new experimental renderer. I think we've got some fixes in the works for 1.16 that might just address this. /cc @lhecker

@zadjii-msft zadjii-msft added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Product-Terminal The new Windows Terminal. labels Aug 8, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 8, 2022
@lhecker lhecker self-assigned this Aug 8, 2022
@lhecker lhecker mentioned this issue Mar 6, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite AtlasEngine to allow arbitrary overhangs microsoft/terminal
3 participants
@lhecker @zadjii-msft @ghillb