Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions Order Rearranged on Save #13285

Open
Tracked by #12400
paradokx opened this issue Jun 12, 2022 · 1 comment
Open
Tracked by #12400

Actions Order Rearranged on Save #13285

paradokx opened this issue Jun 12, 2022 · 1 comment
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@paradokx
Copy link

Windows Terminal version

1.13.11431.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

  1. Start Windows Terminal.
  2. Open WT settings ctrl + ,
  3. Navigate to Actions-menu
  4. Press Save

Expected Behavior

Expected the settings to be saved unaltered.

Actual Behavior

Order in which entries appear is rearranged.

202206_WindowsTerminal_Bug_Actions
@paradokx paradokx added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jun 12, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 12, 2022
@zadjii-msft
Copy link
Member

zadjii-msft commented Jun 13, 2022 •
edited
Loading

I suppose this is a real bug. IIRC we're just passing a Map into that vector, so there's no guarantee of internal sort ordering of the various key chords for a single action. Probably should be done as a part of #12388

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Priority-3 A description (P3) Area-Settings UI Anything specific to the SUI labels Jun 13, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jun 13, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 13, 2022
@zadjii-msft zadjii-msft mentioned this issue Jun 13, 2022
Open
12 tasks
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@zadjii-msft @paradokx