Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command-line to toggle visibility #13276

Open
gapf2010 opened this issue Jun 11, 2022 · 5 comments
Open

Command-line to toggle visibility #13276

gapf2010 opened this issue Jun 11, 2022 · 5 comments
Labels
Area-Commandline wt.exe's commandline arguments Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@gapf2010
Copy link

gapf2010 commented Jun 11, 2022

Description of the new feature/enhancement

I'm proposing a command-line option to toggle the visibility of the terminal window. It should do exactly that: if I run (for instance) "wt --toggle" it should create a new window with default profile and show it (if no window exists) or show the current window (if one already exists). If the window is currently being displayed, running "wt --toggle" should hide the window and focus the previously selected application. This can be complemented with an option to make it that if "wt --toggle" creates the window, then it won't make it visible (useful on startup of terminal). A second run of "wt --toggle" will make the window visible.

Proposed technical implementation details (optional)

Not sure about how to do this. Maybe a switch that will run the same "toggle visibility" internal command of terminal, or something? however that does not seem to be exactly what I described above.

@gapf2010 gapf2010 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 11, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 11, 2022
@zadjii-msft
Copy link
Member

This kinda sounds like the globalSummon action to me, but with more steps. Not saying that it's invalid, but I suppose I'm curious - is there a reason globalSummon doesn't work for your use case/?

Presumably, it wouldn't be too hard to just plumb through wt summon as a globalSummon action, if you really needed this on the commandline for some reason.

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 13, 2022
@gapf2010
Copy link
Author

This kinda sounds like the globalSummon action to me, but with more steps. Not saying that it's invalid, but I suppose I'm curious - is there a reason globalSummon doesn't work for your use case/?

Presumably, it wouldn't be too hard to just plumb through wt summon as a globalSummon action, if you really needed this on the commandline for some reason.

Hi. Well, for me gobalSummons does not work, because it seems I cannot bind F12 to summon the terminal. F12 works on Linux and OSX, but for some reason it does not work on Windows for me. However, I found my Lenovo PC has a way to run a custom command when pressing F12, and that's what I'd like to use with this option I'm proposing.

Thanks.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 14, 2022
@zadjii-msft
Copy link
Member

I found my Lenovo PC has a way to run a custom command when pressing F12

Ah, well, that might explain why you can't bind F12 in the Terminal - I suppose the PC has already stolen that keybinding away from us 😄

@gapf2010
Copy link
Author

gapf2010 commented Jun 14, 2022

I found my Lenovo PC has a way to run a custom command when pressing F12

Ah, well, that might explain why you can't bind F12 in the Terminal - I suppose the PC has already stolen that keybinding away from us 😄

I thought the same, but then I noticed that the Lenovo software actually does not bind to F12, but to Fn+F12 and even then, it's not currently enabled. F12 is not bound to anything AFAIK, because pressing it on a software that uses it (like Edge or Chrome) does what it's supposed to do on that software, so no other app uses F12 exclusively. If you can configure your terminal to open with F12 and could share the config here, I'd appreciate it. Anyway, I still think my original request would be useful.

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Commandline wt.exe's commandline arguments and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. labels Aug 10, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 10, 2022
@zadjii-msft
Copy link
Member

Note: this is as described in #12135.

I'll use this for the summon subcommand, and then leave the other issue for --profile

@zadjii-msft zadjii-msft added Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 10, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Commandline wt.exe's commandline arguments Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants