Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Things we can fix when we can safely rev the DefTerm interface #13249

Closed
1 task done
zadjii-msft opened this issue Jun 8, 2022 · 1 comment
Closed
1 task done

Things we can fix when we can safely rev the DefTerm interface #13249

zadjii-msft opened this issue Jun 8, 2022 · 1 comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-DefApp Issue-Scenario Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Jun 8, 2022 •
edited
Loading

We're in a world where we can't really change much of the delegation console interface. We can't really change how OpenConsole communicates with conhost, cause there are newer OpenConsoles that run on older conhosts, and vice-versa. Should we ever find ourselves in a place where we can rev that boundary, we should make sure to also fix the following:
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Scenario Area-DefApp labels Jun 8, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jun 8, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 8, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 8, 2022
@zadjii-msft
Copy link
Member Author

You know what, we actually didn't do the crazy thing we were going to do in #13247 that prompted this issue in the first place. We're closing this for now. If we ever need it again, we know where to find it.

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-DefApp Issue-Scenario Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@zadjii-msft