Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "close to tray" #12933

Open
Tracked by #10448
NSurtsev opened this issue Apr 19, 2022 · 6 comments
Open
Tracked by #10448

Add support for "close to tray" #12933

NSurtsev opened this issue Apr 19, 2022 · 6 comments
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@NSurtsev
Copy link

NSurtsev commented Apr 19, 2022 •
edited
Loading

Windows Terminal version

1.12.10732.0

Windows build number

19044.1645

Other Software

No response

Steps to reproduce

Enable "always display icon in system tray" and then close the window of Terminal

Expected Behavior

Window is closed, but Terminal is still running with icon in system tray (the same behavior for any program in system tray, that's why programs usually have option in Settings to be set to system tray!)
To close Terminal completely you should go to system tray and do it manually with right-click on icon and "close" (or smth)

Actual Behavior

Despite I have Terminal in system tray, after I close the window... the Terminal is simply completely closed...
@NSurtsev NSurtsev added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Apr 19, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 19, 2022
@zadjii-msft
Copy link
Member

If you hover over the icon in the tray, does it disappear/? (I think I've seen this in the past on Debug builds. We may want to fix that if it's present in release builds as well)

When you right click on the tray icon, and select "windows >", are there any listed there?

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 19, 2022
@NSurtsev
Copy link
Author

NSurtsev commented Apr 19, 2022 •
edited
Loading

If you hover over the icon in the tray, does it disappear/? (I think I've seen this in the past on Debug builds. We may want to fix that if it's present in release builds as well)

When you right click on the tray icon, and select "windows >", are there any listed there?

It doesn't disappear.
"Windows" shows my current Terminal windows (usually 1 or 2 if I launch Quake mode too).
I considered it just wrong implementation of functions. There is also option in Settings "hide Terminal in system tray when it is minimized". I don't know why anyone could need this option enabled with "Minimize" button (we usually minimize to still see program on taskbar and be able to just Alt-TAB, if needed), but that's actually how I want it to work (and how it should work!) with "Close" button and system tray enabled by default!

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 19, 2022
@zadjii-msft
Copy link
Member

Ah yea, sorry, I misread that. You want close to minimize/hide to the tray, rather than close the window. I'm pretty sure we've had a discussion about this in the paste, lemme find it...

@NSurtsev
Copy link
Author

Ah yea, sorry, I misread that. You want close to minimize/hide to the tray, rather than close the window. I'm pretty sure we've had a discussion about this in the paste, lemme find it...

Exactly! This is default when we are talking about programs, showing on system tray! It's very strange that Terminal doesn't behave this way. I checked for issues for last half a year, but didn't see discussion about it, maybe I missed it.

@zadjii-msft zadjii-msft added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Area-Windowing Window frame, quake mode, tearout and removed Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Apr 21, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 21, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Apr 21, 2022
@zadjii-msft zadjii-msft changed the title Weird behavior of X (close window) button Add support for "close to tray" Apr 21, 2022
@zadjii-msft zadjii-msft mentioned this issue Apr 21, 2022
Open
15 tasks
@JVimes
Copy link

JVimes commented Jun 6, 2023

This is worded roughly as "Window close button minimizes instead of terminating" in KeePass. Maybe that's useful for us.

@lhecker lhecker mentioned this issue Jun 6, 2023
Open
@carlos-zamora carlos-zamora mentioned this issue Jun 12, 2024
Closed
@eusousu
Copy link

eusousu commented Jun 19, 2024

Coming from linux the ability to have the terminal always accessible (i.e. it never really closes) is a most wealcome feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@JVimes @eusousu @zadjii-msft @NSurtsev