Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Incomplete" color schemes are rejected as if they don't exist (possibly only if in fragment) #11457

Open
Diablo-D3 opened this issue Oct 7, 2021 · 8 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone

Comments

@Diablo-D3
Copy link

Diablo-D3 commented Oct 7, 2021

Windows Terminal version (or Windows build number)

1.11.2421.0, 1.10.2383.0

Other Software

No response

Steps to reproduce

Use a color scheme that is "incomplete" in a fragment, use the scheme name's in your default profile.

Example:

{
  "schemes": [
    {
      "name": "Test",
      "background": "#000000",
      "foreground": "#000000",
      "black": "#002b36",
      "red": "#6a4d53",
      "green": "#468666",
      "yellow": "#75896c",
      "blue": "#002b36",
      "magenta": "#6a4d53",
      "cyan": "#468666",
      "white": "#75896c",
      "brightBlack": "#002b36",
      "brightRed": "#002b36",
      "brightGreen": "#002b36",
      "brightYellow": "#002b36",
      "brightBlue": "#002b36",
      "brightMagenta": "#002b36",
      "brightCyan": "#002b36",
      "brightWhite": "#002b36"
    }
  ]
}

Drop in %LOCALAPPDATA\Microsoft\Windows Terminal\Fragments\Test\Test.json, and change settings.json's defaults: colorScheme to Test. Launch WT, get greatly misleading warning.

Notice the use of #11456 here. Else, everything seems to be listed as per the documentation on schemes.

Change "Magenta" to "Purple" on both lines, and watch the fragment suddenly be discoverable and work.

Also note: the colors in this scheme are garbage on purpose, if they're ugly, its working.

Expected Behavior

Either working behavior (with the missing colors replaced with Campbell's) and/or a warning specifically telling me what is wrong with the scheme. At no point should WT tell the user that the scheme doesn't exist without any other warnings that specifically state the scheme was found, but is incomplete.

Actual Behavior

On launch with incomplete scheme in fragment, but specified in settings.json

image

Notice the lack of saying the color scheme exists, but misses elements; it just claims it never existed ever, which leads to a day long wild goose chase.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 7, 2021
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 8, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 8, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Mar 8, 2022
@SufyaanKhateeb
Copy link

If no one is assigned, maybe I look into this.

@zadjii-msft
Copy link
Member

@SufyaanKhateeb Go right ahead ☺️

@SufyaanKhateeb
Copy link

While building the application I am running into

  D:\Windows Kits\10\Include\10.0.22621.0\shared\TraceLoggingActivity.h(439,1): fatal  error C1060: compiler is out of heap space (compiling source file Ne
wTabMenuTests.cpp) [C:\Users\sufya\OneDrive\Desktop\Sufyaan\windows-terminal\src\cascadia\LocalTests_SettingsModel\SettingsModel.LocalTests.vcxproj]
  D:\Windows Kits\10\Include\10.0.22621.0\shared\TraceLoggingActivity.h(847,1): fatal  error C1060: compiler is out of heap space (compiling source file Se
rializationTests.cpp) [C:\Users\sufya\OneDrive\Desktop\Sufyaan\windows-terminal\src\cascadia\LocalTests_SettingsModel\SettingsModel.LocalTests.vcxproj]

How much memory space does this require for building?

@zadjii-msft
Copy link
Member

Like, at least 4GB. The precompiled header files for XAML are outrageously big, and they need to be entirely stuffed into memory all at once.

@MaximilianMeiler
Copy link

First-time contributor here - I'm interested in working on this issue. I'll try to get the environment set up - perhaps the error should be expanded to include what sections of which schemes are missing?

@SufyaanKhateeb
Copy link

Yes, you can go ahead. I didn't get time to check it out.

@MaximilianMeiler
Copy link

image

I've set up my development environment (including an installation of the Windows 10.0.22621.0 SDK), but am still getting this error on launch. I'm not able to find the "retarget solution" option for the OpenConsole file and have tried a few workarounds, to no success - any aid would be appreciated.

@MaximilianMeiler
Copy link

MaximilianMeiler commented Feb 5, 2024

I was able to solve the above issue by un/reinstalling my SDKs and performing a repair on Visual Studio. However, i'm now getting a different error when attempting to build with powershell:
image

Attempting to build with the command prompt gives the powershell version error as well.

As before, any assistance is appreciated.

Edit: Now I'm getting the "error NETSDK1004: Assets file not found. Run a NuGet package restore to generate this file." error instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants