-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Incomplete" color schemes are rejected as if they don't exist (possibly only if in fragment) #11457
Comments
If no one is assigned, maybe I look into this. |
@SufyaanKhateeb Go right ahead |
While building the application I am running into
How much memory space does this require for building? |
Like, at least 4GB. The precompiled header files for XAML are outrageously big, and they need to be entirely stuffed into memory all at once. |
First-time contributor here - I'm interested in working on this issue. I'll try to get the environment set up - perhaps the error should be expanded to include what sections of which schemes are missing? |
Yes, you can go ahead. I didn't get time to check it out. |
Windows Terminal version (or Windows build number)
1.11.2421.0, 1.10.2383.0
Other Software
No response
Steps to reproduce
Use a color scheme that is "incomplete" in a fragment, use the scheme name's in your default profile.
Example:
Drop in
%LOCALAPPDATA\Microsoft\Windows Terminal\Fragments\Test\Test.json
, and changesettings.json
'sdefaults: colorScheme
toTest
. Launch WT, get greatly misleading warning.Notice the use of #11456 here. Else, everything seems to be listed as per the documentation on schemes.
Change "Magenta" to "Purple" on both lines, and watch the fragment suddenly be discoverable and work.
Also note: the colors in this scheme are garbage on purpose, if they're ugly, its working.
Expected Behavior
Either working behavior (with the missing colors replaced with Campbell's) and/or a warning specifically telling me what is wrong with the scheme. At no point should WT tell the user that the scheme doesn't exist without any other warnings that specifically state the scheme was found, but is incomplete.
Actual Behavior
On launch with incomplete scheme in fragment, but specified in
settings.json
Notice the lack of saying the color scheme exists, but misses elements; it just claims it never existed ever, which leads to a day long wild goose chase.
The text was updated successfully, but these errors were encountered: