Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for a confirmation prompt before closing a tab #11335

Closed
aminya opened this issue Sep 26, 2021 · 3 comments
Closed

Option for a confirmation prompt before closing a tab #11335

aminya opened this issue Sep 26, 2021 · 3 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@aminya
Copy link

aminya commented Sep 26, 2021

Description of the new feature/enhancement

It would be nice to have an option so that there is a confirmation prompt before the user closes a tab.

This is useful for long-running tabs that are doing something in the background and the user might close them by mistake.

Proposed technical implementation details (optional)

@aminya aminya added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 26, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 26, 2021
@heysujal
Copy link
Contributor

heysujal commented Sep 26, 2021

I would like to work on this issue. Can anyone please guide me on how to proceed ?

@zadjii-msft
Copy link
Member

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #6549 for more discussion.

/dup #6549

@heysujal I wrote a pseudo-spec for this over in #6549 (comment). I haven't had the opportunity to socialize that with the rest of the team really, but if we had code in front of us I'm sure we'd find the time 😝 If you can find a way to detect that there are multiple client apps connected, that might be a useful place to start. ConptyConnection is the class that actually represents the connection between the Terminal and the client app, so that's where I'd start.

@ghost
Copy link

ghost commented Sep 27, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Sep 27, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 27, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants