Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Windows Terminal preview as default terminal not working #10229

Closed
mveril opened this issue May 27, 2021 · 10 comments
Closed

Set Windows Terminal preview as default terminal not working #10229

mveril opened this issue May 27, 2021 · 10 comments
Assignees
Labels
Area-DefApp Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Milestone

Comments

@mveril
Copy link

mveril commented May 27, 2021

Windows Terminal version (or Windows build number)

Windows Terminal preview 1.9.1445.0

Other Software

Microsoft Windows insider preview [version 10.0.21390.1]

Steps to reproduce

  • Open Windows Terminal preview settings
  • Set Windows Terminal Preview as default terminal
  • Save change
  • Open cmd or PowerShell from the start menu

Expected Behavior

The shell should be opened inside the Windows Terminal Preview

Actual Behavior

The shell is open inside conhost

Here is the contents of my current registry corresponding to the console and terminal delegation to Windows Terminal Preview

[HKEY_CURRENT_USER\Console\%%Startup]
"DelegationConsole"="{06EC847C-C0A5-46B8-92CB-7C92F6E35CD5}"
"DelegationTerminal"="{86633F1F-6454-40EC-89CE-DA4EBA977EE2}"
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 27, 2021
@zadjii-msft
Copy link
Member

/feedback

@ghost
Copy link

ghost commented May 27, 2021

Hi there!

Can you please send us feedback with the Feedback Hub with this issue and paste the link here so we can more easily find your crash information on the back end?

Thanks!

image image

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 27, 2021
@zadjii-msft
Copy link
Member

(okay I know it's not a crash, but repro'ing this with the Feedback hub should collect some information that might be useful in tracking down why defterm didn't work)

@mveril
Copy link
Author

mveril commented May 27, 2021

Thank you for your reply.
Please find my feedback here
Just for a little more background if that can help.
When I saw the Windows Terminal preview 1.9 blogpost from @cinnamon-msft , I decided to try this feature and I set it up on my machine before upgrading to build 21390 because the terminal selector was already present in the ConHost settings and I didn't think I needed another build (I was in build 21387). After saving settings, an error message was issued (I can't remember the content sorry) and it did not work. After updating windows to build 21390 it still does not work. Maybe I broke something when I changed the default terminal on build 21387?

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 27, 2021
@miniksa
Copy link
Member

miniksa commented May 27, 2021

It will open in conhost still if the chain activation fails into the Terminal. The registered class IDs for the chain activation are correct for Terminal Preview. For some reason, I do not have access to the feedback, so I will have to come back around to this or ask my team if they know why I cannot get access. Do note this is labeled Alpha and the amount of diagnostics I've put in so far isn't great, so you might have to hang on for a bit while I still work on it.

@zadjii-msft zadjii-msft added the Issue-Bug It either shouldn't be doing this or needs an investigation. label May 27, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone May 27, 2021
@DHowett DHowett added Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 27, 2021
@DHowett DHowett removed the Needs-Tag-Fix Doesn't match tag requirements label May 27, 2021
@mveril
Copy link
Author

mveril commented May 28, 2021

Thank you @miniksa.
I am happy to see that conhost is a failback when the redirection not working. So, in any case, we still have access to our command line apps even if there is an error.
Hope you can access to my feedback and it can help you.
Thank you for this unexpected feature! I never thought it would be possible one day!
If you don't mind and if it is possible, I would very much like you to let me know where the problem is coming from when you know it. I'll be interested to know what's wrong.
Thank you

@miniksa
Copy link
Member

miniksa commented May 28, 2021

I wonder if this is related to #10243....

If I can figure it out, I'll tell you @mveril.

@mveril
Copy link
Author

mveril commented May 31, 2021

Thank you @miniksa

@miniksa
Copy link
Member

miniksa commented Jul 23, 2021

I am hoping #10415 and #10751 have improved this. I'm not certain as I haven't managed to reproduce it, but both of those improved the stability and reliability of handoffs.

@mveril
Copy link
Author

mveril commented Oct 6, 2021

Thank you @miniksa !
Sorry for the delay, I forgot that I had not closed this issue

@mveril mveril closed this as completed Oct 6, 2021
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-DefApp Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants