From 1eb883cec74cfe580c7b40838efb8d8ce6670efc Mon Sep 17 00:00:00 2001 From: Mike Griese Date: Wed, 4 Nov 2020 17:42:00 -0600 Subject: [PATCH] more notes --- src/tools/MonarchPeasantSample/README.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/tools/MonarchPeasantSample/README.md b/src/tools/MonarchPeasantSample/README.md index bdb25741feb..0a348c9a3cf 100644 --- a/src/tools/MonarchPeasantSample/README.md +++ b/src/tools/MonarchPeasantSample/README.md @@ -81,6 +81,13 @@ things that are missing from the sample: - try running `MonarchPeasantSample.exe -s 0` (or `-s 2`) - THIS WILL FAIL, but it _should_ just run the commandline in the monarch (in the case of `-s 0`) or in a new window (in the `-s 1` case) + - The reason this fails is because the Monarch tries to call + `Peasant::ExecuteCommandline`, but the Peasant object doesn't actually + exist anymore (the process is dead!). Three fixes will help here: + - wrap all calls to peasants with try/catch's + - Do the "keep a MRU stack" thing (so we know `-s 0` is now the monarch) + - Do the "wait on Peasant processes" thing, to know to pop #2 from the + map and MRU stack. ## Utilities