From 0b3d8e577dd67985409e4aca4618896f6199cd57 Mon Sep 17 00:00:00 2001 From: Michael Niksa Date: Tue, 20 Apr 2021 11:07:45 -0700 Subject: [PATCH] Use empty version for the OS one instead of looking it up. --- src/cascadia/TerminalSettingsModel/DefaultTerminal.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/cascadia/TerminalSettingsModel/DefaultTerminal.cpp b/src/cascadia/TerminalSettingsModel/DefaultTerminal.cpp index f96df762686..6bc1a18154a 100644 --- a/src/cascadia/TerminalSettingsModel/DefaultTerminal.cpp +++ b/src/cascadia/TerminalSettingsModel/DefaultTerminal.cpp @@ -26,6 +26,12 @@ winrt::hstring DefaultTerminal::Name() const winrt::hstring DefaultTerminal::Version() const { + // If there's no version information... return empty string instead. + if (DelegationConfig::PkgVersion{} == _pkg.terminal.version) + { + return winrt::hstring{}; + } + const auto name = fmt::format(std::wstring_view(RS_(L"TerminalVersionPattern")), _pkg.terminal.version.major, _pkg.terminal.version.minor, _pkg.terminal.version.build, _pkg.terminal.version.revision); return winrt::hstring{ name }; }