{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":100060912,"defaultBranch":"main","name":"terminal","ownerLogin":"microsoft","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-08-11T18:38:22.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6154722?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1725491198.0","currentOid":""},"activityList":{"items":[{"before":"a39a00254d035033329a264ff3c2a8b5c1a62832","after":"012395fd90a9a9f10f21ec14e78d78d0ebdea48f","ref":"refs/heads/feature/llm","pushedAt":"2024-09-05T01:31:26.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"miniksa","name":"Michael Niksa","path":"/miniksa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/18221333?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'origin/main' into feature/llm","shortMessageHtmlLink":"Merge remote-tracking branch 'origin/main' into feature/llm"}},{"before":"90846cec4f0a9f9d6aea57cd346feafa13f6c156","after":null,"ref":"refs/heads/dev/lhecker/17801-scroll-rect-fixup","pushedAt":"2024-09-04T23:06:38.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"}},{"before":"5fdfd51209fc681e66657d6697ce031bc4319619","after":"d2c3cfd1640e4efc70ec61ee350beb19766b9345","ref":"refs/heads/main","pushedAt":"2024-09-04T23:06:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"},"commit":{"message":"Fix ScrollRect to DECCRA translation (#17849)\n\nBy translating the clip rectangle into a source-relative coordinate\r\nspace we can calculate the intersection that must be copied\r\nmuch much more easily. I should've done that from the start.\r\n\r\nCloses #17801\r\n\r\n## Validation Steps Performed\r\n* Test code provided in #17801","shortMessageHtmlLink":"Fix ScrollRect to DECCRA translation (#17849)"}},{"before":"be99f930942f48210d01b41a7577777b5519f372","after":"03fc325ad16fadad39694a55ca0892095f8d3495","ref":"refs/heads/release-1.22","pushedAt":"2024-09-04T20:04:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"},"commit":{"message":"Dedup command history by default (#17852)\n\nUnder ConPTY we don't load any user settings. `SetUpConsole` notes:\n> If we are [ConPTY], we don't want to load any user settings,\n> because that could result in some strange rendering results [...]\n\nThis enables deduplication by default, which I figured wouldn't cause\nany regressions since it's a user-controllable setting anyway, while\nit's clearly something the average user wants enabled, for the same\nreason that PSReadLine has HistoryNoDuplicates enabled by default.\n\nCloses #17797\n\n## Validation Steps Performed\n* Launch conhost, enter 2 commands, press F7, select the older one,\n press Enter, press F7. 2 entries ✅\n* Launch WT, enter 2 commands, press F7, select the older one,\n press Enter, press F7. 2 entries ✅\n\n(cherry picked from commit 5fdfd51209fc681e66657d6697ce031bc4319619)\nService-Card-Id: PVTI_lADOAF3p4s4AmhmQzgSN1FQ\nService-Version: 1.22","shortMessageHtmlLink":"Dedup command history by default (#17852)"}},{"before":"e8c15683a726eccf416d28d9159350ecbe555796","after":"c47d9e1ad9086bc6265188097e85cdc4568ab07b","ref":"refs/heads/release-1.21","pushedAt":"2024-09-04T20:01:01.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"},"commit":{"message":"Dedup command history by default (#17852)\n\nUnder ConPTY we don't load any user settings. `SetUpConsole` notes:\n> If we are [ConPTY], we don't want to load any user settings,\n> because that could result in some strange rendering results [...]\n\nThis enables deduplication by default, which I figured wouldn't cause\nany regressions since it's a user-controllable setting anyway, while\nit's clearly something the average user wants enabled, for the same\nreason that PSReadLine has HistoryNoDuplicates enabled by default.\n\nCloses #17797\n\n## Validation Steps Performed\n* Launch conhost, enter 2 commands, press F7, select the older one,\n press Enter, press F7. 2 entries ✅\n* Launch WT, enter 2 commands, press F7, select the older one,\n press Enter, press F7. 2 entries ✅\n\n(cherry picked from commit 5fdfd51209fc681e66657d6697ce031bc4319619)\nService-Card-Id: PVTI_lADOAF3p4s4AmhmszgSN1FM\nService-Version: 1.21","shortMessageHtmlLink":"Dedup command history by default (#17852)"}},{"before":"53ccff0d69a04da3830ab3af2b9e2e1ee4dce23d","after":null,"ref":"refs/heads/dev/lhecker/17797-dedup-by-default","pushedAt":"2024-09-04T19:57:24.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"}},{"before":"7b50f12a780ec0f8a55e7f04ad12d65b451f7667","after":"5fdfd51209fc681e66657d6697ce031bc4319619","ref":"refs/heads/main","pushedAt":"2024-09-04T19:57:23.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"},"commit":{"message":"Dedup command history by default (#17852)\n\nUnder ConPTY we don't load any user settings. `SetUpConsole` notes:\r\n> If we are [ConPTY], we don't want to load any user settings,\r\n> because that could result in some strange rendering results [...]\r\n\r\nThis enables deduplication by default, which I figured wouldn't cause\r\nany regressions since it's a user-controllable setting anyway, while\r\nit's clearly something the average user wants enabled, for the same\r\nreason that PSReadLine has HistoryNoDuplicates enabled by default.\r\n\r\nCloses #17797\r\n\r\n## Validation Steps Performed\r\n* Launch conhost, enter 2 commands, press F7, select the older one,\r\n press Enter, press F7. 2 entries ✅\r\n* Launch WT, enter 2 commands, press F7, select the older one,\r\n press Enter, press F7. 2 entries ✅","shortMessageHtmlLink":"Dedup command history by default (#17852)"}},{"before":"90cfb33c1350298ebc281ecb34b4378e9bd0e727","after":"be99f930942f48210d01b41a7577777b5519f372","ref":"refs/heads/release-1.22","pushedAt":"2024-09-04T19:56:09.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"},"commit":{"message":"Avoid dropping Esc characters from VT responses (#17833)\n\n`GetChar` checks if the vkey is VK_ESCAPE. `CharToKeyEvents` however\ntries really hard to figure out the vkeys of all characters.\nTo avoid these issues all we need to do is to simply use the existing\n`WriteString` function we already use for all other VT responses.\nIf it's good for conhost responses, it's good for ConPTY responses.\n\nAdditionally, this removes another `IsVtInputEnabled` which was\nredundant with `WriteString` which worked exactly the same internally.\n\nCloses #17813\nCloses #17851\nProbably also related to #17823\n\n* Wrote a small app to send and receive a DA1 request. It works ✅\n* WSL already worked to begin with (and still works now) ✅\n* No double-encoding of mouse input events ✅\n\n(cherry picked from commit 7b50f12a780ec0f8a55e7f04ad12d65b451f7667)\nService-Card-Id: PVTI_lADOAF3p4s4AmhmQzgSa4RU PVTI_lADOAF3p4s4AmhmQzgStRA0\nService-Version: 1.22","shortMessageHtmlLink":"Avoid dropping Esc characters from VT responses (#17833)"}},{"before":"9fb694ef898738dc59b668161b75ccf8f98de37c","after":null,"ref":"refs/heads/dev/lhecker/17813-esc-response","pushedAt":"2024-09-04T13:47:03.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"}},{"before":"6e5827add56f8c6d89f0f7d880238d9e178f9401","after":"7b50f12a780ec0f8a55e7f04ad12d65b451f7667","ref":"refs/heads/main","pushedAt":"2024-09-04T13:47:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Avoid dropping Esc characters from VT responses (#17833)\n\n`GetChar` checks if the vkey is VK_ESCAPE. `CharToKeyEvents` however\r\ntries really hard to figure out the vkeys of all characters.\r\nTo avoid these issues all we need to do is to simply use the existing\r\n`WriteString` function we already use for all other VT responses.\r\nIf it's good for conhost responses, it's good for ConPTY responses.\r\n\r\nAdditionally, this removes another `IsVtInputEnabled` which was\r\nredundant with `WriteString` which worked exactly the same internally.\r\n\r\nCloses #17813\r\nCloses #17851\r\nProbably also related to #17823\r\n\r\n## Validation Steps Performed\r\n* Wrote a small app to send and receive a DA1 request. It works ✅\r\n* WSL already worked to begin with (and still works now) ✅\r\n* No double-encoding of mouse input events ✅","shortMessageHtmlLink":"Avoid dropping Esc characters from VT responses (#17833)"}},{"before":"17a55da0f9889aafd84df024299982e7b94f5482","after":"6e5827add56f8c6d89f0f7d880238d9e178f9401","ref":"refs/heads/main","pushedAt":"2024-09-04T13:36:32.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"microsoft-github-policy-service[bot]","name":null,"path":"/apps/microsoft-github-policy-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/95686?s=80&v=4"},"commit":{"message":"Pass through DCS responses when VT input mode is disabled (#17845)\n\n## Summary of the Pull Request\n\nWhen an app makes a VT request that returns a `DCS` response, and it\nhasn't also enabled VT input mode, the new passthrough implementation\nloses that response. All the app receives is an `Alt`+`\\` key press\ntriggered by the `ST` terminator. This PR fixes that issue.\n\n## References and Relevant Issues\n\nThis is one of the unresolved issues tracked in #17643.\n\n## Detailed Description of the Pull Request / Additional comments\n\nThe way `DCS` sequences are handled in the input state machine engine is\nby returning a nullptr from `ActionDcsDispatch`, which tells the state\nmachine to ignore that content. But the sequence is still buffered, and\nwhen the `ST` terminator is eventually received, that buffer is flushed,\nwhich passes the whole thing through to the app.\n\nOriginally this only worked when VT input mode was enabled, otherwise\nthe `ST` sequence is converted into a key press, and the buffered `DCS`\ncontent is lost. The way it works now is we set a flag when the `DCS`\nintroducer is received, and if that flag is set when the `ST` arrives,\nwe know to trigger a flush rather a key press.\n\n## Validation Steps Performed\n\nI've tested a `DA3` request from the cmd shell (i.e. `echo ^[[=c`), and\nconfirmed that now works as expected. I've also hacked Windows Terminal\nto disable win32-input mode, so I could check how it works with conpty\nclients generating standard VT input, and confirmed that an `Alt`+`\\`\nkeypress is still translated correctly.","shortMessageHtmlLink":"Pass through DCS responses when VT input mode is disabled (#17845)"}},{"before":null,"after":"629ed07021d9ba985a788bc950ba081397244b25","ref":"refs/heads/dev/cazamor/SUI/nullable-color-picker","pushedAt":"2024-09-03T20:56:00.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"carlos-zamora","name":"Carlos Zamora","path":"/carlos-zamora","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11050425?s=80&v=4"},"commit":{"message":"temp commit 2","shortMessageHtmlLink":"temp commit 2"}},{"before":null,"after":"d814c1c42abb733facece88621ceb5d452b3c12d","ref":"refs/heads/dev/lhecker/17817-screen-info-close","pushedAt":"2024-09-03T16:29:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Restore contents when a screen info is closed","shortMessageHtmlLink":"Restore contents when a screen info is closed"}},{"before":"9c715498bc9ac81edce36b9d44ab622a15fa10ae","after":"53ccff0d69a04da3830ab3af2b9e2e1ee4dce23d","ref":"refs/heads/dev/lhecker/17797-dedup-by-default","pushedAt":"2024-09-03T15:37:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Forgot one","shortMessageHtmlLink":"Forgot one"}},{"before":null,"after":"9c715498bc9ac81edce36b9d44ab622a15fa10ae","ref":"refs/heads/dev/lhecker/17797-dedup-by-default","pushedAt":"2024-09-03T15:30:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Dedup command history by default","shortMessageHtmlLink":"Dedup command history by default"}},{"before":"76d850765ad6d8e673991c9ce58a66be8335aed3","after":"90846cec4f0a9f9d6aea57cd346feafa13f6c156","ref":"refs/heads/dev/lhecker/17801-scroll-rect-fixup","pushedAt":"2024-09-03T14:15:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Fix ScrollRect to DECCRA translation","shortMessageHtmlLink":"Fix ScrollRect to DECCRA translation"}},{"before":"e254475c29ff9c406b0381d0b63fd090da80d44c","after":"9fb694ef898738dc59b668161b75ccf8f98de37c","ref":"refs/heads/dev/lhecker/17813-esc-response","pushedAt":"2024-09-03T13:59:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Properly fix it","shortMessageHtmlLink":"Properly fix it"}},{"before":"986378afab55679651c076d85a2970c4b3bd5875","after":"76d850765ad6d8e673991c9ce58a66be8335aed3","ref":"refs/heads/dev/lhecker/17801-scroll-rect-fixup","pushedAt":"2024-09-03T13:35:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Fix ScrollRect to DECCRA translation","shortMessageHtmlLink":"Fix ScrollRect to DECCRA translation"}},{"before":null,"after":"0d7b4e714d51864d7e115be1f4543dabe379d31f","ref":"refs/heads/dev/lhecker/17847-quit-crash","pushedAt":"2024-09-03T11:15:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Fix crash in AppHost::_QuitRequested","shortMessageHtmlLink":"Fix crash in AppHost::_QuitRequested"}},{"before":null,"after":"986378afab55679651c076d85a2970c4b3bd5875","ref":"refs/heads/dev/lhecker/17801-scroll-rect-fixup","pushedAt":"2024-09-02T16:36:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"476bc1c47528a13b8589d264ee70b7caa6ba08c7","after":"e254475c29ff9c406b0381d0b63fd090da80d44c","ref":"refs/heads/dev/lhecker/17813-esc-response","pushedAt":"2024-09-02T16:16:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Revert & Add comments","shortMessageHtmlLink":"Revert & Add comments"}},{"before":null,"after":"476bc1c47528a13b8589d264ee70b7caa6ba08c7","ref":"refs/heads/dev/lhecker/17813-esc-response","pushedAt":"2024-08-30T15:58:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Avoid dropping Esc characters from VT responses","shortMessageHtmlLink":"Avoid dropping Esc characters from VT responses"}},{"before":"814c357d303c5c84e2a3bbfe84e9be7d7c7ae73b","after":"87fc91477250e033c8eb3717abfc0025639f5149","ref":"refs/heads/dev/lhecker/dark-mode-alt","pushedAt":"2024-08-30T11:59:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"aebba904c1da577c718c4e98587864766eaaecc1","after":"1c9991d687256248404b636a92f012c82710d9e8","ref":"refs/heads/dev/lhecker/dark-mode","pushedAt":"2024-08-30T11:59:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"4200ea4293cc7cb2879b7dd8be115d4a5148a3bf","after":"a39a00254d035033329a264ff3c2a8b5c1a62832","ref":"refs/heads/feature/llm","pushedAt":"2024-08-30T01:31:17.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"miniksa","name":"Michael Niksa","path":"/miniksa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/18221333?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'origin/main' into feature/llm","shortMessageHtmlLink":"Merge remote-tracking branch 'origin/main' into feature/llm"}},{"before":"16e54e97b384ea2c66a2a8c998a406db0fdff89c","after":"a3c12bf3da080c29a73440ff95f2cb737e38fd91","ref":"refs/heads/dev/lhecker/conpty-message-window","pushedAt":"2024-08-29T23:18:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Avoid focus loops in ConPTY","shortMessageHtmlLink":"Avoid focus loops in ConPTY"}},{"before":"90eacb7cdb5a7b3715416b7a1967837ee238f33e","after":"16e54e97b384ea2c66a2a8c998a406db0fdff89c","ref":"refs/heads/dev/lhecker/conpty-message-window","pushedAt":"2024-08-29T23:15:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Avoid focus loops in ConPTY","shortMessageHtmlLink":"Avoid focus loops in ConPTY"}},{"before":"577e9c279b101d5f6b7ad56b5ceac048df3ed728","after":"90eacb7cdb5a7b3715416b7a1967837ee238f33e","ref":"refs/heads/dev/lhecker/conpty-message-window","pushedAt":"2024-08-29T23:08:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Avoid focus loops in ConPTY","shortMessageHtmlLink":"Avoid focus loops in ConPTY"}},{"before":"9fced65bf56c8d5567143e00f31595fb560ce612","after":"577e9c279b101d5f6b7ad56b5ceac048df3ed728","ref":"refs/heads/dev/lhecker/conpty-message-window","pushedAt":"2024-08-29T21:50:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Use HWND_MESSAGE for ConPTY & avoid focus loops","shortMessageHtmlLink":"Use HWND_MESSAGE for ConPTY & avoid focus loops"}},{"before":"9bece0b13069ef701b354fe28a4f579dbc39ee79","after":null,"ref":"refs/heads/dev/migrie/a-focus-thing","pushedAt":"2024-08-29T21:19:17.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"zadjii-msft","name":"Mike Griese","path":"/zadjii-msft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/18356694?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAErU7eVgA","startCursor":null,"endCursor":null}},"title":"Activity · microsoft/terminal"}