You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current SuperBenchmark project pins setuptools to v65.7.0 to avoid breaking changes introduced in setuptools v66.0.0. This pin was added in PR #483 to handle changes from pypa/setuptools#2497 and pypa/setuptools#3772.
Problem
However, this pin is becoming increasingly problematic:
More and more projects are using newer versions of setuptools, leading to potential conflicts when using SuperBenchmark alongside these projects.
The original issue that prompted the pin (removal of LegacyVersion support in v66.0.0) has been fully resolved in the Python ecosystem. The majority of packages now use PEP 440 compliant versions.
Users are missing out on important improvements and bug fixes introduced in newer setuptools versions, including:
Support for PEP 625 package name normalization (v69.3.0)
Improved metadata handling and PKG-INFO generation (v68.2.0)
Better atomicity when writing PKG-INFO files (v68.2.0)
Enhanced PyProject.toml support (v68.1.0)
Various performance improvements and bug fixes
Proposal
I propose we:
Remove the setuptools pin from SuperBenchmark requirements
Test compatibility with latest setuptools version
Update any necessary code to work with newer setuptools features
Update documentation to reflect the changes
This will allow users to benefit from newer setuptools features while maintaining compatibility with modern Python packaging practices.
Impact
The change should be low risk since:
The original issue that prompted the pin (LegacyVersion support) is no longer relevant in today's Python ecosystem
Most packages now follow PEP 440 version guidelines
Recent setuptools versions have been stable and widely adopted
The benefit would be improved compatibility with the broader Python ecosystem and access to newer packaging features.
Does this seem like a reasonable approach? I'd be happy to help with implementation and testing if needed.
The text was updated successfully, but these errors were encountered:
Background
The current SuperBenchmark project pins setuptools to v65.7.0 to avoid breaking changes introduced in setuptools v66.0.0. This pin was added in PR #483 to handle changes from pypa/setuptools#2497 and pypa/setuptools#3772.
Problem
However, this pin is becoming increasingly problematic:
More and more projects are using newer versions of setuptools, leading to potential conflicts when using SuperBenchmark alongside these projects.
The original issue that prompted the pin (removal of LegacyVersion support in v66.0.0) has been fully resolved in the Python ecosystem. The majority of packages now use PEP 440 compliant versions.
Users are missing out on important improvements and bug fixes introduced in newer setuptools versions, including:
Proposal
I propose we:
This will allow users to benefit from newer setuptools features while maintaining compatibility with modern Python packaging practices.
Impact
The change should be low risk since:
The benefit would be improved compatibility with the broader Python ecosystem and access to newer packaging features.
Does this seem like a reasonable approach? I'd be happy to help with implementation and testing if needed.
The text was updated successfully, but these errors were encountered: