Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Add docker tests - ensures docker image doesn't break while new features are added #358

Closed
yalaudah opened this issue Jun 10, 2020 · 1 comment · Fixed by #388
Closed

Add docker tests - ensures docker image doesn't break while new features are added #358

yalaudah opened this issue Jun 10, 2020 · 1 comment · Fixed by #388
Assignees
@fazamani
Labels
multi-GPU anything related to ability to use multiple GPUs Prior: High Status: Done Working related to the is completed Type: Gap Not feature but a missing item to an existing feature
Milestone
V0.2 [June release]

Comments

@yalaudah
Copy link
Contributor

Add a new job (in parrallel with the setup job) to build and run the docker image. We can do this this for both local and distributed train, in addition to running the notebooks and testing a pretrained model.
@yalaudah yalaudah added multi-GPU anything related to ability to use multiple GPUs Prior: High Type: Gap Not feature but a missing item to an existing feature labels Jun 10, 2020
@maxkazmsft maxkazmsft added this to the V0.2 [June release] milestone Jun 10, 2020
@maxkazmsft maxkazmsft changed the title Add docker tests to ensure it doesn't break while new features are added Add docker tests - ensures docker image doesn't break while new features are added Jun 10, 2020
@fazamani fazamani self-assigned this Jul 1, 2020
@fazamani
Copy link
Collaborator

fazamani commented Jul 1, 2020

Due to time constraint and hardware limitation (build VM has single GPU), this issue is de-scoped to the following:

  • Add a job daisy-changed to the last job in the main_build to test that the docker builds successfully.
  • We will revisit the parallel jobs run in a later time.

@maxkazmsft

@fazamani fazamani linked a pull request Jul 2, 2020 that will close this issue
docker build test #388
Merged
@fazamani fazamani added the Status: Done Working related to the is completed label Jul 2, 2020
@fazamani fazamani closed this as completed Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fazamani fazamani

Labels
multi-GPU anything related to ability to use multiple GPUs Prior: High Status: Done Working related to the is completed Type: Gap Not feature but a missing item to an existing feature
Projects
None yet
Milestone
V0.2 [June release]
Development

Successfully merging a pull request may close this issue.

docker build test microsoft/seismic-deeplearning
3 participants
@yalaudah @maxkazmsft @fazamani