Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Notebooks not using same seed as experiments, affects reproducibibilty across notebooks and experiments #244

Closed
yalaudah opened this issue Apr 6, 2020 · 2 comments · Fixed by #247
Closed

Notebooks not using same seed as experiments, affects reproducibibilty across notebooks and experiments #244

yalaudah opened this issue Apr 6, 2020 · 2 comments · Fixed by #247
Assignees
@yalaudah
Labels
Prior: Medium Status: Done Working related to the is completed Type: Bug Something isn't working
Milestone
Ver 1.0

Comments

@yalaudah
Copy link
Contributor

yalaudah commented Apr 6, 2020

In the notebooks, the seeds are defined manually (see below) instead of reading from the config file like the experiments. This should be fixed to get reproducible results across notebooks and experiments.

np.random.seed(seed=1234)

import torch

torch.backends.cudnn.benchmark = True
torch.manual_seed(1234)
if torch.cuda.is_available():
    torch.cuda.manual_seed_all(1234)
@yalaudah yalaudah self-assigned this Apr 6, 2020
@yalaudah yalaudah added this to the Ver 1.0 milestone Apr 6, 2020
@yalaudah yalaudah added Prior: Medium Type: Bug Something isn't working labels Apr 7, 2020
@yalaudah yalaudah mentioned this issue Apr 7, 2020
Merged
@yalaudah yalaudah added the Status: Done Working related to the is completed label Apr 7, 2020
@yalaudah yalaudah linked a pull request Apr 7, 2020 that will close this issue
update notebook seeds #247
Merged
@yalaudah
Copy link
Contributor Author

Fixed in #247

@yalaudah
Copy link
Contributor Author

Fixed in #247

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yalaudah yalaudah

Labels
Prior: Medium Status: Done Working related to the is completed Type: Bug Something isn't working
Projects
None yet
Milestone
Ver 1.0
Development

Successfully merging a pull request may close this issue.

update notebook seeds
1 participant
@yalaudah