Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Range function in prepare_dutchf3.py potentially missing out on data when creating horz_locations and vert_locations #184

Closed
kirasoderstrom opened this issue Feb 6, 2020 · 1 comment

Comments

@kirasoderstrom
Copy link
Collaborator

I created splits for two different volumes and compared them. If you have dimensions for example (400, 500, 350) with a stride of 50 and patch of 100. I would expect the master branch for crosslines to go from horz_locations = range(0, 400-100, 50) so it would go from 0 to 300 at 50 stride intervals so we would see a print out up to 250 there but I would like to see it go out to 300 since we have data until 400. Although if we add 300+1 this would fix this. So I am recommending to consider including a plus one at that point incase the dimensions are exactly on a mark like this.

image

@kirasoderstrom
Copy link
Collaborator Author

Taken care of in #185

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant