Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused functionality #227

Open
achamayou opened this issue Oct 18, 2024 · 1 comment
Open

Clean up unused functionality #227

achamayou opened this issue Oct 18, 2024 · 1 comment

Comments

@achamayou
Copy link
Member

The repository contains a number of SGX-specific and did:web-specific tests. CCF has already dropped support for SGX, and scitt will likely follow shortly (#226), which means that the SGX-specific logic should be removed.

The existing did:web resolver could go one of two ways:

  1. A conversion to curl, which can be made available in the confidential containers used to run on SEV-SNP - the associated attestation functionality can be dropped, since it runs in TCB/attested boundary
  2. Removal, there are no known users for the did:web functionality, it is not clear whether maintaining this feature is worthwhile.

Regardless of the choice being made, there should be no dependency on did:web for testing, or performance testing, since it is not representative of typical scitt-ccf-ledger use. In other words, it is fine to have tests that exercise did:web but not to have feature tests that rely on did:web to exercise a particular aspect of the ledger.

@andpiccione
Copy link
Member

Just FYI, we are planning to drop the did:web functionality, we have an internal task to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants