Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sparse: Check for superceding parents in input #125

Closed
derrickstolee opened this issue Sep 24, 2019 · 2 comments
Closed

Sparse: Check for superceding parents in input #125

derrickstolee opened this issue Sep 24, 2019 · 2 comments
Assignees
@derrickstolee
Labels
bug correctness issues polish
Milestone
EA

Comments

@derrickstolee
Copy link
Contributor

BUG: if we run git sparse-checkout set A A/B, then A is registered as a recursive closure AND A/B is marked as a recursive closure. This also means that A is marked as a parent path.

This results in Git complaining that the patterns are not cone-style, and reverts to the slow pattern matching algorithm.

To fix, consider removing paths from the "parent" list if they are in the "recursive" list. Further: remove children from the recursive list.
@derrickstolee derrickstolee self-assigned this Sep 24, 2019
@derrickstolee derrickstolee added bug correctness issues polish labels Sep 24, 2019
@derrickstolee derrickstolee added this to the EA milestone Sep 24, 2019
@derrickstolee
Copy link
Contributor Author

Fix is in microsoft/git#203.

@derrickstolee
Copy link
Contributor Author

And we took that fix in #122.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derrickstolee derrickstolee

Labels
bug correctness issues polish
Projects
None yet
Milestone
EA
Development

No branches or pull requests
1 participant
@derrickstolee