Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Git hooks in Rush #821

Closed
natalieethell opened this issue Sep 12, 2018 · 1 comment
Closed

[rush] Git hooks in Rush #821

natalieethell opened this issue Sep 12, 2018 · 1 comment
Labels
effort: easy Probably a quick fix. Want to contribute? :-) enhancement The issue is asking for a new feature or design change help wanted If you're looking to contribute, this issue is a good place to start!

Comments

@natalieethell
Copy link
Contributor

Could Rush support git hooks?

@octogonz
Copy link
Collaborator

If we had Rush manage this, I'm thinking it could be extremely simple. I don't even think we'd need to cook up a fancy config section. It could just be a folder like common/config/git-hooks that gets copied into .git/hooks, deleting whatever is already there. Maybe this happens automatically as part of rush install.

When we looked at Husky, it's focused on mapping Git's scripts to NPM lifecycle scripts, which is great for getting people started. But at the point where you're setting up a serious multi-project monorepo, I don't think that developer's going to be intimidated by the requirement to write a Bash script that invokes their script.

@octogonz octogonz added enhancement The issue is asking for a new feature or design change help wanted If you're looking to contribute, this issue is a good place to start! effort: easy Probably a quick fix. Want to contribute? :-) labels Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: easy Probably a quick fix. Want to contribute? :-) enhancement The issue is asking for a new feature or design change help wanted If you're looking to contribute, this issue is a good place to start!
Projects
None yet
Development

No branches or pull requests

2 participants