IClusterChangeListener singleton ?

[3GDXC]

I would like to register additional IClusterChangeListerners to the DI system; so I may hook into these events and update the Microsoft.Extensions.Diagnostics.HealthChecks and subsequently the health UI reports will display cluster status.

[3GDXC]

Ideally the internal sealed class ClusterManager should be made non-sealed public class so a developer could derive from it and implement addition logic/rules etc.

i.e. if a cluster is added/removed we'd like a message set to a remote alerting/monitoring systems

[Tratcher]

Multiple listeners are supported:

reverse-proxy/src/ReverseProxy/Service/Management/ClusterManager.cs

Line 16 in 05a60d0

public ClusterManager(IDestinationManagerFactory destinationManagerFactory, IEnumerable<IClusterChangeListener> changeListeners)

Singleton has to do with object lifetime (it lives for the lifetime of the app), not how many there are.

See #125 for related discussions about proxy health.

Ideally the internal sealed class ClusterManager should be made non-sealed public class so a developer could derive from it and implement addition logic/rules etc.

i.e. if a cluster is added/removed we'd like a message set to a remote alerting/monitoring systems

You should be able to do that with the IClusterChangeListeners.

[3GDXC]

@Tratcher odd; as when I've tried to add a IClusterChangeListeners to the DI system; it never gets created? or called, I will review add get back or create a repo to reproduce.

[karelz]

Triage: We are pretty sure it works (we're using it for HealthChecks). Can you please provide (simplified) repro for us?

[karelz]

Triage: No repro, closing. Feel free to reopen if there is more evidence. Thanks!