Migrating from custom gateway API in dotnet 6 to YARP

[aswinfrancis91]

I have a dotnet 6 API project that acts as a gateway. This gateway project has controllers that accept the request and then send the request to our microservices via SDKs we have for them. I am now trying to implement YARP so that devs don't have to write code in our gateway whenever they have created a new endpoint in one of the microservices. However we have consumers for our existing endpoints in gateway and over last couple of months they are a bit of mess. There isn't a common convention for them. So I wrote a config as seen below

{
  "ReverseProxy": {
    "Routes": {
      "route1": {
        "ClusterId": "cluster1",
        "Match": {
          "Path": "/api/{version}/{service}/{**remainder}"
        },
        "Transforms": [
          {
            "PathPattern": "/M{service}/api/{version}"
          }
        ]
      }
    },
    "Clusters": {
      "cluster1": {
        "Destinations": {
          "common": {
            "Address": "http://external.com"
          }
        }
      }
    }
  }
}

The problem I face is some that with this config some of the actions hit controllers in my project but some are being proxied. For example I have below two endpoints:

1. http://mysite.local/MyGatewayProject/api/v123/Users/Information
2. http://mysite.local/MyGatewayProject/api/v123/Users/Address

The second one hit my breakpoint in controller but the first one is proxied and forwarded to my microservice and fails as the endpoint isn't available. I see below log lines

[16:24:45 INF] Request starting HTTP/2 GET http://mysite.local/MyGatewayProject/api/v123/Users/Information - -
[16:24:45 VRB] All hosts are allowed.
[16:24:45 DBG] The request path  does not match the path filter
[16:24:45 DBG] The request path  does not match the path filter
[16:24:45 DBG] 1 candidate(s) found for the request path '/api/v123/Users/Information '
[16:24:45 DBG] Endpoint 'route1' with route pattern '/api/{version}/{service}/{**remainder}' is valid for the request path '/api/v123/Users/Information'
[16:24:45 DBG] Request matched endpoint 'route1'
[16:24:45 INF] Executing endpoint 'route1'
[16:24:45 INF] Proxying to http://external.com/api/v123/Users/Information HTTP/2 RequestVersionOrLower 

The one that works logs this

[16:38:47 INF] Request starting HTTP/2 GET http://mysite.local/MyGatewayProject/api/v123/Users/Address - -
[16:38:47 VRB] All hosts are allowed.
[16:38:47 DBG] The request path  does not match the path filter
[16:38:47 DBG] The request path  does not match the path filter
[16:38:47 DBG] 2 candidate(s) found for the request path '/api/v123/Users/Address'
[16:38:47 DBG] Endpoint 'WebApi.GatewayProjectName.Controllers.AddressController.GetAddress (WebApi.GatewayProjectName)' with route pattern 'api/v123/Users/Address' is valid for the request path '/api/v123/Users/Address'
[16:38:47 DBG] Endpoint 'route1' with route pattern '/api/{version}/{service}/{**remainder}' is valid for the request path '/api/v123/Users/Address'
[16:38:47 DBG] Request matched endpoint 'WebApi.GatewayProjectName.Controllers.AddressController.GetAddress (WebApi.GatewayProjectName)'
[16:38:48 DBG] Authorization was successful.
[16:38:48 INF] Executing endpoint 'WebApi.GatewayProjectName.Controllers.AddressController.GetAddress (WebApi.GatewayProjectName)'
[16:38:48 INF] Route matched with {action = "GetAddress", controller = "Address"}. Executing controller action with signature Microsoft.AspNetCore.Mvc.IActionResult GetAddress() on controller WebApi.GatewayProjectName.Controllers.AddressController (WebApi.GatewayProjectName).
...
... goes on like this

What might be wrong here. Both controller have similar signature with route and action. I use serilog and added below config but I don't think i am seeing any logs related to YARP

  "Serilog": {
    "MinimumLevel": {
      "Default": "Verbose",
      "Override": {
        "Microsoft": "Verbose",
        "Yarp": "Verbose",
        "Microsoft.Hosting.Lifetime": "Verbose"
      }
    },

[aswinfrancis91]

After breaking my head over this for some time I found the problem to be Consumes and Produces attribute I had on controller :|
I removed it now all of them working as expected. However some of the actions that has consumes are failing now. Commenting it works. Any idea how I can have these attributes and not break routing logic

[Produces("application/json", "application/xml")]
[Consumes("application/json", "application/xml")]

Update:
When i searched for the attribute i saw that another user faced a similar problem
#2597

[MihaZupan]

The ConsumesAttribute is a routing filter. If the incoming request does not have the appropriate ContentType set, your action won't be considered. Valid requests should not be impacted as your controller will remain a valid routing candidate.

Is the thing that's broken that you were testing that invalid requests result in a 415 response?