Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug): update scrapeConfig to filer retina container specifically #770

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

SRodi
Copy link
Member

@SRodi SRodi commented Sep 23, 2024

Description

  • update additionalScrapeConfigs to filter containers named retina (retina agent)
  • this will exclude retina-operator container in retina-operator pod

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

fix #177

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Deployed unmanaged Prometheus as per doc instructions, see here

The target for retina-operator is no longer appearing since it is no longer scraped

image

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

Signed-off-by: Simone Rodigari <srodigari@microsoft.com>
@SRodi SRodi added this pull request to the merge queue Sep 24, 2024
Merged via the queue into microsoft:main with commit f1b8345 Sep 24, 2024
22 checks passed
@SRodi SRodi deleted the fix/unhealthy-prom-target branch September 24, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retina-operator shows up as unhealthy in Prometheus targets
2 participants